mbox series

[ndctl,0/4] Some fixups and improvements ndctl monitor

Message ID 20180807131756.23673-1-qi.fuli@jp.fujitsu.com (mailing list archive)
Headers show
Series Some fixups and improvements ndctl monitor | expand

Message

QI Fuli Aug. 7, 2018, 1:17 p.m. UTC
Fix a couple of issues about log collection, and add [Install] section
to systemd unit file of ndclt-monitor.

Signed-off-by: QI Fuli <qi.fuli@jp.fujitsu.com>
---
QI Fuli (4):
  ndctl, monitor: fix the lack of detection of invalid path of log file
  ndctl, monitor: set default log destination to syslog if "--daemon" is specified
  ndctl, monitor: add timestamp and pid to log messages in log_file()
  ndctl, monitor: add [Install] Section to systemd unit file of ndctl-monitor

 Documentation/ndctl/ndctl-monitor.txt | 16 +++++++++++++++-
 ndctl/monitor.c                       | 27 ++++++++++++++++++++++++---
 ndctl/monitor.conf                    |  2 ++
 ndctl/ndctl-monitor.service           |  3 +++
 4 files changed, 44 insertions(+), 4 deletions(-)

Comments

Verma, Vishal L Aug. 10, 2018, 8:42 p.m. UTC | #1
On Tue, 2018-08-07 at 22:17 +0900, QI Fuli wrote:
> Fix a couple of issues about log collection, and add [Install] section
> to systemd unit file of ndclt-monitor.
> 
> Signed-off-by: QI Fuli <qi.fuli@jp.fujitsu.com>
> ---
> QI Fuli (4):
>   ndctl, monitor: fix the lack of detection of invalid path of log file
>   ndctl, monitor: set default log destination to syslog if "--daemon" is specified
>   ndctl, monitor: add timestamp and pid to log messages in log_file()
>   ndctl, monitor: add [Install] Section to systemd unit file of ndctl-monitor
> 
>  Documentation/ndctl/ndctl-monitor.txt | 16 +++++++++++++++-
>  ndctl/monitor.c                       | 27 ++++++++++++++++++++++++---
>  ndctl/monitor.conf                    |  2 ++
>  ndctl/ndctl-monitor.service           |  3 +++
>  4 files changed, 44 insertions(+), 4 deletions(-)
> 
Hi Qi,

These look good, applied.

Thanks,
	-Vishal