mbox series

[v2,0/4] bugfix and optimize for drivers/nvdimm

Message ID 20200819020503.3079-1-thunder.leizhen@huawei.com (mailing list archive)
Headers show
Series bugfix and optimize for drivers/nvdimm | expand

Message

Zhen Lei Aug. 19, 2020, 2:04 a.m. UTC
v1 --> v2:
1. Add Fixes for Patch 1-2
2. Slightly change the subject and description of Patch 1
3. Add a new trivial Patch 4, I just found that yesterday.

v1:
I found a memleak when I learned the drivers/nvdimm code today. And I also
added a sanity check for priv->bus_desc.provider_name, because strdup()
maybe failed. Patch 3 is a trivial source code optimization.

Zhen Lei (4):
  libnvdimm: fix memmory leaks in of_pmem.c
  libnvdimm: add sanity check for provider_name in
    of_pmem_region_probe()
  libnvdimm/bus: simplify walk_to_nvdimm_bus()
  libnvdimm/region: reduce an unnecessary if branch in
    nd_region_create()

 drivers/nvdimm/bus.c         | 7 +++----
 drivers/nvdimm/of_pmem.c     | 7 +++++++
 drivers/nvdimm/region_devs.c | 5 +----
 3 files changed, 11 insertions(+), 8 deletions(-)

Comments

Markus Elfring Aug. 19, 2020, 12:20 p.m. UTC | #1
> v1 --> v2:
> 1. Add Fixes for Patch 1-2
> 2. Slightly change the subject and description of Patch 1>   libnvdimm: fix memmory leaks in of_pmem.c
…

I suggest to avoid a typo in such a patch subject.

Regards,
Markus
Zhen Lei Aug. 19, 2020, 1:30 p.m. UTC | #2
On 8/19/2020 8:20 PM, Markus Elfring wrote:
>> v1 --> v2:
>> 1. Add Fixes for Patch 1-2
>> 2. Slightly change the subject and description of Patch 1
> …
>>   libnvdimm: fix memmory leaks in of_pmem.c
> …
> 
> I suggest to avoid a typo in such a patch subject.

OK, Thanks for reminding me.

> 
> Regards,
> Markus
> 
>