[v3,0/2] ndctl/namespace:Fix and improve write-infoblock

Message

Tarun Sahu April 26, 2022, 5:20 p.m. UTC

This series resolves some issues with write-infoblock 
command and provide support to write-infoblock for sector 
mode namespace

write-infoblock command has issues regarding updating the 
align, uuid, parent_uuid. In case of no parameter passed 
for it, this command used to overwrite the existing values 
with defaults.

In PATCH 1/2 these parameters will be set to their original 
values, incase, values hasn't been passed in command 
arguments

write-infoblock command doesn't have support for sector/BTT 
mode namespaces. They can be converted to fsdax, but can 
not be written being in sector mode.

In PATCH 2/2, It creates a functionality which write 
infoblock of Sector/BTT namespace. Currently only uuid, 
parent_uuid can be updated. In future, Support for other 
parameters can easily be integrated in the
functionality.

---
v2:
  Updated the commit message (rephrasing) in patch 1/2
  Moved the ns_info struct to namespace.c from namespace.h
  put the results after --- to avoid long commit message

v3:
  reformat the commit message to meet 100 column condition

Tarun-Sahu (2):
  ndctl/namespace:Fix multiple issues with write-infoblock
  ndctl/namespace:Implement write-infoblock for sector mode namespaces

 ndctl/namespace.c | 308 +++++++++++++++++++++++++++++++++-------------
 1 file changed, 225 insertions(+), 83 deletions(-)

Comments

Tarun Sahu May 13, 2022, 7:07 a.m. UTC | #1

Hi,

Just a gentle reminder, Kindly Let me know if any changes are needed in
this patchset.

Thank you,
Tarun


On Tue, 2022-04-26 at 22:50 +0530, Tarun Sahu wrote:
> This series resolves some issues with write-infoblock 
> command and provide support to write-infoblock for sector 
> mode namespace
> 
> write-infoblock command has issues regarding updating the 
> align, uuid, parent_uuid. In case of no parameter passed 
> for it, this command used to overwrite the existing values 
> with defaults.
> 
> In PATCH 1/2 these parameters will be set to their original 
> values, incase, values hasn't been passed in command 
> arguments
> 
> write-infoblock command doesn't have support for sector/BTT 
> mode namespaces. They can be converted to fsdax, but can 
> not be written being in sector mode.
> 
> In PATCH 2/2, It creates a functionality which write 
> infoblock of Sector/BTT namespace. Currently only uuid, 
> parent_uuid can be updated. In future, Support for other 
> parameters can easily be integrated in the
> functionality.
> 
> ---
> v2:
>   Updated the commit message (rephrasing) in patch 1/2
>   Moved the ns_info struct to namespace.c from namespace.h
>   put the results after --- to avoid long commit message
> 
> v3:
>   reformat the commit message to meet 100 column condition
> 
> Tarun-Sahu (2):
>   ndctl/namespace:Fix multiple issues with write-infoblock
>   ndctl/namespace:Implement write-infoblock for sector mode
> namespaces
> 
>  ndctl/namespace.c | 308 +++++++++++++++++++++++++++++++++-----------
> --
>  1 file changed, 225 insertions(+), 83 deletions(-)
>