[v6,0/7] badblocks improvement for multiple bad block ranges

Message

Coly Li July 21, 2022, 12:11 p.m. UTC

This is the v6 version of the badblocks improvement series, which makes
badblocks APIs to handle multiple ranges in bad block table.

The change comparing to previous v5 version is the modification against
review comments from Xiao Ni,
- Typo fixes in code comments or commit logs.
- The over thought checking conditions like '<=' are simplified as '<'.
- Some unnecessary condition checks are removed.
- In _badblocks_set(), if prev returned from prev_badblocks() is <0, set 
  it properly before jumping to update_sectors. This helps to avoid un-
  necessary looping.

There is NO in-memory or on-disk format change in the whole series, all
existing API and data structures are consistent. This series just only
improve the code algorithm to handle more corner cases, the interfaces
are same and consistency to all existing callers (md raid and nvdimm
drivers).

The original motivation of the change is from the requirement from our
customer, that current badblocks routines don't handle multiple ranges.
For example if the bad block setting range covers multiple ranges from
bad block table, only the first two bad block ranges merged and rested
ranges are intact. The expected behavior should be all the covered
ranges to be handled.

All the patches are tested by modified user space code and the code
logic works as expected. The modified user space testing code is
provided in the last patch. The testing code is an example how the
improved code is tested.

The whole change is divided into 6 patches to make the code review more
clear and easier. If people prefer, I'd like to post a single large
patch finally after the code review accomplished.

Please review the code and response. Thank you all in advance.

Coly Li

Cc: Dan Williams <[e-mail]>
Cc: Geliang Tang <[e-mail]>
Cc: Hannes Reinecke <[e-mail]>
Cc: Jens Axboe <[e-mail]>
Cc: NeilBrown <[e-mail]>
Cc: Richard Fan <[e-mail]>
Cc: Vishal L Verma <[e-mail]>
Cc: Wols Lists <[e-mail]>
Cc: Xiao Ni <[e-mail]>
---

Coly Li (6):
  badblocks: add more helper structure and routines in badblocks.h
  badblocks: add helper routines for badblock ranges handling
  badblocks: improve badblocks_set() for multiple ranges handling
  badblocks: improve badblocks_clear() for multiple ranges handling
  badblocks: improve badblocks_check() for multiple ranges handling
  badblocks: switch to the improved badblock handling code

 block/badblocks.c         | 1609 ++++++++++++++++++++++++++++++-------
 include/linux/badblocks.h |   30 +
 2 files changed, 1345 insertions(+), 294 deletions(-)

Comments

Li Nan May 23, 2023, 2:38 a.m. UTC | #1

Hi Coly Li,

Recently, I have been trying to fix the bug of backblocks settings, and 
I found that your patch series has already fixed the bug. This patch 
series has not been applied to mainline at present, may I ask if you 
still plan to continue working on it?

Coly Li May 23, 2023, 4:38 a.m. UTC | #2

> 2023年5月23日 10:38，Li Nan <[e-mail]> 写道：
> 
> Hi Coly Li,
> 
> Recently, I have been trying to fix the bug of backblocks settings, and I found that your patch series has already fixed the bug. This patch series has not been applied to mainline at present, may I ask if you still plan to continue working on it?

Sure, I will post an update version for your testing.

Coly Li