| Message ID | 057ada9967af9e029d2d32cef87b5ab87db4de47.1486750247.git.linda.knippers@hpe.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Feb 13, 2017 at 8:27 AM, Linda Knippers <linda.knippers@hpe.com> wrote:
> Newline in MODULE_PARM_DESC messes up the modprobe output so remove it.
Yes, looks good. When this "messes up" does that mean the output less
pretty, or do you know if it breaks scripts parsing the output? Just
want to be clear on the effects of this change.
On 02/13/2017 12:32 PM, Dan Williams wrote: > On Mon, Feb 13, 2017 at 8:27 AM, Linda Knippers <linda.knippers@hpe.com> wrote: >> Newline in MODULE_PARM_DESC messes up the modprobe output so remove it. > > Yes, looks good. When this "messes up" does that mean the output less > pretty, or do you know if it breaks scripts parsing the output? Just > want to be clear on the effects of this change. If you do a 'modinfo nfit', it puts "(bool)" on a separate line. That's unlike all the other parameters. If someone is parsing the output of modinfo, they may not get the type. Without my patch, you get this: parm: force_enable_dimms:Ignore _STA (ACPI DIMM device) status (bool) parm: scrub_timeout:Initial scrub timeout in seconds (uint) parm: scrub_overflow_abort:Number of times we overflow ARS results before abort (uint) parm: disable_vendor_specific:Limit commands to the publicly specified set (bool) parm: default_dsm_family:Try this DSM type first when identifying NVDIMM family (int) instead of this: parm: force_enable_dimms:Ignore _STA (ACPI DIMM device) status (bool) parm: scrub_timeout:Initial scrub timeout in seconds (uint) parm: scrub_overflow_abort:Number of times we overflow ARS results before abort (uint) parm: disable_vendor_specific:Limit commands to the publicly specified set (bool) parm: default_dsm_family:Try this DSM type first when identifying NVDIMM family (int) -- ljk
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index e38773f..6c522c8 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -49,7 +49,7 @@ static bool disable_vendor_specific; module_param(disable_vendor_specific, bool, S_IRUGO); MODULE_PARM_DESC(disable_vendor_specific, - "Limit commands to the publicly specified set\n"); + "Limit commands to the publicly specified set"); static int default_dsm_family = -1; module_param(default_dsm_family, int, S_IRUGO);
Newline in MODULE_PARM_DESC messes up the modprobe output so remove it. Signed-off-by: Linda Knippers <linda.knippers@hpe.com> --- drivers/acpi/nfit/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)