From patchwork Thu Mar 10 19:38:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wilcox, Matthew R" X-Patchwork-Id: 8559821 Return-Path: X-Original-To: patchwork-linux-nvdimm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3C91F9F46A for ; Thu, 10 Mar 2016 19:39:03 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BAF7120380 for ; Thu, 10 Mar 2016 19:39:01 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E760920377 for ; Thu, 10 Mar 2016 19:39:00 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id C74AC1A1EF8; Thu, 10 Mar 2016 11:39:15 -0800 (PST) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by ml01.01.org (Postfix) with ESMTP id BEE381A1EF8 for ; Thu, 10 Mar 2016 11:39:13 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP; 10 Mar 2016 11:38:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,317,1455004800"; d="scan'208";a="921186159" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 10 Mar 2016 11:38:58 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 10 Mar 2016 11:38:58 -0800 Received: from fmsmsx114.amr.corp.intel.com ([169.254.6.167]) by FMSMSX157.amr.corp.intel.com ([169.254.14.204]) with mapi id 14.03.0248.002; Thu, 10 Mar 2016 11:38:57 -0800 From: "Wilcox, Matthew R" To: Jan Kara , "linux-fsdevel@vger.kernel.org" , "linux-xtensa@linux-xtensa.org" Subject: RE: [PATCH 03/12] mm: Remove VM_FAULT_MINOR Thread-Topic: [PATCH 03/12] mm: Remove VM_FAULT_MINOR Thread-Index: AQHRewG0DqlwiyEYXU6K8NgQheyzyZ9TEmPA Date: Thu, 10 Mar 2016 19:38:56 +0000 Message-ID: <100D68C7BA14664A8938383216E40DE0422079B3@FMSMSX114.amr.corp.intel.com> References: <1457637535-21633-1-git-send-email-jack@suse.cz> <1457637535-21633-4-git-send-email-jack@suse.cz> In-Reply-To: <1457637535-21633-4-git-send-email-jack@suse.cz> Accept-Language: en-CA, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.1.200.106] MIME-Version: 1.0 Cc: NeilBrown , "linux-nvdimm@lists.01.org" X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP You've clearly fixed a bug in xtensa here ;-) Wonder why nobody noticed that counter was always 0? +++ b/arch/xtensa/mm/fault.c @@ -146,7 +146,7 @@ good_area: perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, regs, address); if (flags & VM_FAULT_MAJOR) perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ, 1, regs, address); - else if (flags & VM_FAULT_MINOR) + else perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN, 1, regs, address); return; diff --git a/include/linux/mm.h b/include/linux/mm.h index 516e14944339..37f319d7636e 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1051,8 +1051,6 @@ static inline void clear_page_pfmemalloc(struct page *page) * just gets major/minor fault counters bumped up. */ -#define VM_FAULT_MINOR 0 /* For backwards compat. Remove me quickly. */ - #define VM_FAULT_OOM 0x0001 #define VM_FAULT_SIGBUS 0x0002 #define VM_FAULT_MAJOR 0x0004