| Message ID | 1437674328-11206-1-git-send-email-vishal.l.verma@intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6b47496a6fc8 |
| Delegated to: | Dan Williams |
| Headers | show |
On 07/23/2015 08:58 PM, Vishal Verma wrote: > Based on a patch: c8fa317 brd: Request from fdisk 4k alignment > by Boaz Harrosh <boaz@plexistor.com>, allow fdisk to create properly > aligned partitions for DAx. This will also cause mkfs.ext4 to emit a > warning if using a file system block size of less than PAGE_SIZE > > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com> > Cc: Matthew Wilcox <matthew.r.wilcox@intel.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Boaz Harrosh <boaz@plexistor.com> ACK Thanks Sir Boaz > Cc: Elliott, Robert <Elliott@hp.com> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> > --- > > From the discussion, it sounds like we all agree that we don't want to force > mkfs to create 4K block only file systems. > > drivers/nvdimm/pmem.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c > index ade9eb9..bcf48f1 100644 > --- a/drivers/nvdimm/pmem.c > +++ b/drivers/nvdimm/pmem.c > @@ -162,6 +162,7 @@ static int pmem_attach_disk(struct nd_namespace_common *ndns, > return -ENOMEM; > > blk_queue_make_request(pmem->pmem_queue, pmem_make_request); > + blk_queue_physical_block_size(pmem->pmem_queue, PAGE_SIZE); > blk_queue_max_hw_sectors(pmem->pmem_queue, UINT_MAX); > blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY); > queue_flag_set_unlocked(QUEUE_FLAG_NONROT, pmem->pmem_queue); >
On Thu, 2015-07-23 at 11:58 -0600, Vishal Verma wrote: > Based on a patch: c8fa317 brd: Request from fdisk 4k alignment > by Boaz Harrosh <boaz@plexistor.com>, allow fdisk to create properly > aligned partitions for DAx. This will also cause mkfs.ext4 to emit a > warning if using a file system block size of less than PAGE_SIZE > > Cc: Dan Williams <dan.j.williams@intel.com> > Cc: Ross Zwisler <ross.zwisler@linux.intel.com> > Cc: Matthew Wilcox <matthew.r.wilcox@intel.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Boaz Harrosh <boaz@plexistor.com> > Cc: Elliott, Robert <Elliott@hp.com> > Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> Acked-by: Ross Zwisler <ross.zwisler@linux.intel.com>
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c index ade9eb9..bcf48f1 100644 --- a/drivers/nvdimm/pmem.c +++ b/drivers/nvdimm/pmem.c @@ -162,6 +162,7 @@ static int pmem_attach_disk(struct nd_namespace_common *ndns, return -ENOMEM; blk_queue_make_request(pmem->pmem_queue, pmem_make_request); + blk_queue_physical_block_size(pmem->pmem_queue, PAGE_SIZE); blk_queue_max_hw_sectors(pmem->pmem_queue, UINT_MAX); blk_queue_bounce_limit(pmem->pmem_queue, BLK_BOUNCE_ANY); queue_flag_set_unlocked(QUEUE_FLAG_NONROT, pmem->pmem_queue);
Based on a patch: c8fa317 brd: Request from fdisk 4k alignment by Boaz Harrosh <boaz@plexistor.com>, allow fdisk to create properly aligned partitions for DAx. This will also cause mkfs.ext4 to emit a warning if using a file system block size of less than PAGE_SIZE Cc: Dan Williams <dan.j.williams@intel.com> Cc: Ross Zwisler <ross.zwisler@linux.intel.com> Cc: Matthew Wilcox <matthew.r.wilcox@intel.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Boaz Harrosh <boaz@plexistor.com> Cc: Elliott, Robert <Elliott@hp.com> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com> --- From the discussion, it sounds like we all agree that we don't want to force mkfs to create 4K block only file systems. drivers/nvdimm/pmem.c | 1 + 1 file changed, 1 insertion(+)