diff mbox

[ndctl,v2,1/2] ndctl: fix a segfault in parse-options.c

Message ID 1464037676-5776-2-git-send-email-vishal.l.verma@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Verma, Vishal L May 23, 2016, 9:07 p.m. UTC 
Running something like ndctl create-namespace --list-cmds
would reliably segfault ndctl due to a null pointer dereference.

Add a check before the dereference to fix it.

Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 util/parse-options.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
diff mbox

Patch

diff --git a/util/parse-options.c b/util/parse-options.c
index f170eb0..387eecd 100644
--- a/util/parse-options.c
+++ b/util/parse-options.c
@@ -472,8 +472,9 @@  int parse_options_subcommand(int argc, const char **argv, const struct option *o
 		}
 		exit(130);
 	case PARSE_OPT_LIST_SUBCMDS:
-		for (int i = 0; subcommands[i]; i++)
-			printf("%s ", subcommands[i]);
+		if (subcommands)
+			for (int i = 0; subcommands[i]; i++)
+				printf("%s ", subcommands[i]);
 		exit(130);
 	default: /* PARSE_OPT_UNKNOWN */
 		if (ctx.argv[0][1] == '-') {