diff mbox

[1/8,linux-next] libnvdimm, namespace: update message level on smaller reservations

Message ID 1480706397-20954-1-git-send-email-fabf@skynet.be (mailing list archive)
State New, archived
Headers show

Commit Message

Fabian Frederick Dec. 2, 2016, 7:19 p.m. UTC
kernel command lines like memmap=1M!512M gave no pmem outputs
without debugging.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 drivers/nvdimm/namespace_devs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Dan Williams Dec. 2, 2016, 7:45 p.m. UTC | #1
On Fri, Dec 2, 2016 at 11:19 AM, Fabian Frederick <fabf@skynet.be> wrote:
> kernel command lines like memmap=1M!512M gave no pmem outputs
> without debugging.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>  drivers/nvdimm/namespace_devs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
> index abe5c6b..b00045b 100644
> --- a/drivers/nvdimm/namespace_devs.c
> +++ b/drivers/nvdimm/namespace_devs.c
> @@ -1532,8 +1532,8 @@ struct nd_namespace_common *nvdimm_namespace_common_probe(struct device *dev)
>
>         size = nvdimm_namespace_capacity(ndns);
>         if (size < ND_MIN_NAMESPACE_SIZE) {
> -               dev_dbg(&ndns->dev, "%pa, too small must be at least %#x\n",
> -                               &size, ND_MIN_NAMESPACE_SIZE);
> +               dev_warn(&ndns->dev, "%pa, too small must be at least %#x\n",
> +                        &size, ND_MIN_NAMESPACE_SIZE);

This is too noisy as it will fire every time a new namespace is
created since they always start out zero-sized.  I'd recommend booting
with libnvdimm.dyndbg on the kernel command or something similar.
diff mbox

Patch

diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c
index abe5c6b..b00045b 100644
--- a/drivers/nvdimm/namespace_devs.c
+++ b/drivers/nvdimm/namespace_devs.c
@@ -1532,8 +1532,8 @@  struct nd_namespace_common *nvdimm_namespace_common_probe(struct device *dev)
 
 	size = nvdimm_namespace_capacity(ndns);
 	if (size < ND_MIN_NAMESPACE_SIZE) {
-		dev_dbg(&ndns->dev, "%pa, too small must be at least %#x\n",
-				&size, ND_MIN_NAMESPACE_SIZE);
+		dev_warn(&ndns->dev, "%pa, too small must be at least %#x\n",
+			 &size, ND_MIN_NAMESPACE_SIZE);
 		return ERR_PTR(-ENODEV);
 	}