| Message ID | 149218910195.3926.13927602427357940056.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ffab9385b314 |
| Headers | show |
On Fri, 2017-04-14 at 09:58 -0700, Dan Williams wrote: > Add support for the ACPI_NFIT_MEM_MAP_FAILED ("map_fail") and > ACPI_NFIT_MEM_HEALTH_ENABLED ("smart_notify") health state flags. The > "map_fail" flag identifies DIMMs that were not mapped into one or > more physical address ranges. The "health_notify" flag indicates > whether platform firmware will send notifications when there is new > SMART health data to consume. > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> > --- > drivers/acpi/nfit/core.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c > index 53943d6f4214..05829de43b1d 100644 > --- a/drivers/acpi/nfit/core.c > +++ b/drivers/acpi/nfit/core.c > @@ -1246,12 +1246,14 @@ static ssize_t flags_show(struct device *dev, > { > u16 flags = to_nfit_memdev(dev)->flags; > > - return sprintf(buf, "%s%s%s%s%s\n", > + return sprintf(buf, "%s%s%s%s%s%s%s\n", > flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save_fail " : > "", > flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore_fail > " : "", > flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush_fail " : > "", > flags & ACPI_NFIT_MEM_NOT_ARMED ? "not_armed " : "", > - flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event > " : ""); > + flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event > " : "", > + flags & ACPI_NFIT_MEM_MAP_FAILED ? "map_fail " : "", > + flags & ACPI_NFIT_MEM_HEALTH_ENABLED ? "smart_notify > " : ""); Thanks for the update! The above change looks good, but we will also need to make the same changes to the dev_info() in acpi_nfit_register_dimms(). -Toshi
diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index 53943d6f4214..05829de43b1d 100644 --- a/drivers/acpi/nfit/core.c +++ b/drivers/acpi/nfit/core.c @@ -1246,12 +1246,14 @@ static ssize_t flags_show(struct device *dev, { u16 flags = to_nfit_memdev(dev)->flags; - return sprintf(buf, "%s%s%s%s%s\n", + return sprintf(buf, "%s%s%s%s%s%s%s\n", flags & ACPI_NFIT_MEM_SAVE_FAILED ? "save_fail " : "", flags & ACPI_NFIT_MEM_RESTORE_FAILED ? "restore_fail " : "", flags & ACPI_NFIT_MEM_FLUSH_FAILED ? "flush_fail " : "", flags & ACPI_NFIT_MEM_NOT_ARMED ? "not_armed " : "", - flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event " : ""); + flags & ACPI_NFIT_MEM_HEALTH_OBSERVED ? "smart_event " : "", + flags & ACPI_NFIT_MEM_MAP_FAILED ? "map_fail " : "", + flags & ACPI_NFIT_MEM_HEALTH_ENABLED ? "smart_notify " : ""); } static DEVICE_ATTR_RO(flags);
Add support for the ACPI_NFIT_MEM_MAP_FAILED ("map_fail") and ACPI_NFIT_MEM_HEALTH_ENABLED ("smart_notify") health state flags. The "map_fail" flag identifies DIMMs that were not mapped into one or more physical address ranges. The "health_notify" flag indicates whether platform firmware will send notifications when there is new SMART health data to consume. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/acpi/nfit/core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)