| Message ID | 149341494418.35578.561981766577089185.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Dan,
[auto build test ERROR on pm/linux-next]
[also build test ERROR on v4.11-rc8 next-20170428]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Dan-Williams/dynamic_hex_dump-cleanup/20170429-135503
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
wget https://raw.githubusercontent.com/01org/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All errors (new ones prefixed by >>):
drivers//rpmsg/virtio_rpmsg_bus.c: In function 'rpmsg_send_offchannel_raw':
>> drivers//rpmsg/virtio_rpmsg_bus.c:602:2: error: implicit declaration of function 'dynamic_hex_dump' [-Werror=implicit-function-declaration]
dynamic_hex_dump("rpmsg_virtio TX: ", DUMP_PREFIX_NONE, 16, 1,
^~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/dynamic_hex_dump +602 drivers//rpmsg/virtio_rpmsg_bus.c
bcabbcca Ohad Ben-Cohen 2011-10-20 596 msg->dst = dst;
bcabbcca Ohad Ben-Cohen 2011-10-20 597 msg->reserved = 0;
bcabbcca Ohad Ben-Cohen 2011-10-20 598 memcpy(msg->data, data, len);
bcabbcca Ohad Ben-Cohen 2011-10-20 599
bcabbcca Ohad Ben-Cohen 2011-10-20 600 dev_dbg(dev, "TX From 0x%x, To 0x%x, Len %d, Flags %d, Reserved %d\n",
0963679c Anna, Suman 2016-08-12 601 msg->src, msg->dst, msg->len, msg->flags, msg->reserved);
211e3a93 Anna, Suman 2016-08-12 @602 dynamic_hex_dump("rpmsg_virtio TX: ", DUMP_PREFIX_NONE, 16, 1,
bcabbcca Ohad Ben-Cohen 2011-10-20 603 msg, sizeof(*msg) + msg->len, true);
bcabbcca Ohad Ben-Cohen 2011-10-20 604
bcabbcca Ohad Ben-Cohen 2011-10-20 605 sg_init_one(&sg, msg, sizeof(*msg) + len);
:::::: The code at line 602 was first introduced by commit
:::::: 211e3a93e5b5933e64ddfb299eee462ac7c7d500 rpmsg: use dynamic_hex_dump for hex dump traces
:::::: TO: Anna, Suman <s-anna@ti.com>
:::::: CC: Bjorn Andersson <bjorn.andersson@linaro.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index 5e66e081027e..00d92b399ddd 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -599,10 +599,8 @@ static int rpmsg_send_offchannel_raw(struct rpmsg_device *rpdev, dev_dbg(dev, "TX From 0x%x, To 0x%x, Len %d, Flags %d, Reserved %d\n", msg->src, msg->dst, msg->len, msg->flags, msg->reserved); -#if defined(CONFIG_DYNAMIC_DEBUG) dynamic_hex_dump("rpmsg_virtio TX: ", DUMP_PREFIX_NONE, 16, 1, msg, sizeof(*msg) + msg->len, true); -#endif sg_init_one(&sg, msg, sizeof(*msg) + len); @@ -687,10 +685,8 @@ static int rpmsg_recv_single(struct virtproc_info *vrp, struct device *dev, dev_dbg(dev, "From: 0x%x, To: 0x%x, Len: %d, Flags: %d, Reserved: %d\n", msg->src, msg->dst, msg->len, msg->flags, msg->reserved); -#if defined(CONFIG_DYNAMIC_DEBUG) dynamic_hex_dump("rpmsg_virtio RX: ", DUMP_PREFIX_NONE, 16, 1, msg, sizeof(*msg) + msg->len, true); -#endif /* * We currently use fixed-sized buffers, so trivially sanitize @@ -801,10 +797,8 @@ static int rpmsg_ns_cb(struct rpmsg_device *rpdev, void *data, int len, struct device *dev = &vrp->vdev->dev; int ret; -#if defined(CONFIG_DYNAMIC_DEBUG) dynamic_hex_dump("NS announcement: ", DUMP_PREFIX_NONE, 16, 1, data, len, true); -#endif if (len != sizeof(*msg)) { dev_err(dev, "malformed ns msg (%d)\n", len);
Now that dynamic_hex_dump() has a fallback in the CONFIG_DYNAMIC_DEBUG=n case we can kill the unnecessary ifdefs in the rpmsg driver. Cc: Ohad Ben-Cohen <ohad@wizery.com> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/rpmsg/virtio_rpmsg_bus.c | 6 ------ 1 file changed, 6 deletions(-)