[ndctl,1/4] util: mark badblocks helpers static

Commit Message

Dan Williams May 11, 2017, 10:01 p.m. UTC

These helpers are only used internal to util/json.c.

Signed-off-by: Dan Williams <[e-mail]>
---
 util/json.c |    6 +++---
 util/json.h |    6 ------
 2 files changed, 3 insertions(+), 9 deletions(-)

Patch

diff --git a/util/json.c b/util/json.c
index 0092017262bd..b2c84181cadb 100644
--- a/util/json.c
+++ b/util/json.c
@@ -356,7 +356,7 @@  static struct json_object *dev_badblocks_to_json(struct ndctl_region *region,
 	return NULL;
 }
 
-struct json_object *util_pfn_badblocks_to_json(struct ndctl_pfn *pfn,
+static struct json_object *util_pfn_badblocks_to_json(struct ndctl_pfn *pfn,
 		bool include_media_errors, unsigned int *bb_count)
 {
 	struct ndctl_region *region = ndctl_pfn_get_region(pfn);
@@ -374,7 +374,7 @@  struct json_object *util_pfn_badblocks_to_json(struct ndctl_pfn *pfn,
 			include_media_errors, bb_count);
 }
 
-struct json_object *util_btt_badblocks_to_json(struct ndctl_btt *btt,
+static struct json_object *util_btt_badblocks_to_json(struct ndctl_btt *btt,
 		bool include_media_errors, unsigned int *bb_count)
 {
 	struct ndctl_region *region = ndctl_btt_get_region(btt);
@@ -393,7 +393,7 @@  struct json_object *util_btt_badblocks_to_json(struct ndctl_btt *btt,
 			include_media_errors, bb_count);
 }
 
-struct json_object *util_dax_badblocks_to_json(struct ndctl_dax *dax,
+static struct json_object *util_dax_badblocks_to_json(struct ndctl_dax *dax,
 		bool include_media_errors, unsigned int *bb_count)
 {
 	struct ndctl_region *region = ndctl_dax_get_region(dax);
diff --git a/util/json.h b/util/json.h
index b3bc2084b621..1a6caeeb6e9e 100644
--- a/util/json.h
+++ b/util/json.h
@@ -13,12 +13,6 @@  struct json_object *util_namespace_to_json(struct ndctl_namespace *ndns,
 		bool include_idle, bool include_dax, bool include_media_errs);
 struct daxctl_region;
 struct daxctl_dev;
-struct json_object *util_dax_badblocks_to_json(struct ndctl_dax *dax,
-		bool include_media_errors, unsigned int *bb_count);
-struct json_object *util_pfn_badblocks_to_json(struct ndctl_pfn *pfn,
-		bool include_media_errors, unsigned int *bb_count);
-struct json_object *util_btt_badblocks_to_json(struct ndctl_btt *btt,
-		bool include_media_errors, unsigned int *bb_count);
 struct json_object *util_region_badblocks_to_json(struct ndctl_region *region,
 		bool include_media_errors, unsigned int *bb_count);
 struct json_object *util_daxctl_region_to_json(struct daxctl_region *region,