From patchwork Fri Jun 9 05:27:44 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 9777219 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C2E7760393 for ; Fri, 9 Jun 2017 05:34:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B39301FE8B for ; Fri, 9 Jun 2017 05:34:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A59722843C; Fri, 9 Jun 2017 05:34:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 609191FE8B for ; Fri, 9 Jun 2017 05:34:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 7441820945528; Thu, 8 Jun 2017 22:33:02 -0700 (PDT) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 04AF721A143FE for ; Thu, 8 Jun 2017 22:33:01 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jun 2017 22:34:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,316,1493708400"; d="scan'208";a="112795568" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.125]) by fmsmga006.fm.intel.com with ESMTP; 08 Jun 2017 22:34:10 -0700 Subject: [ndctl PATCH] util: distinguish error codes for sysfs_{read, write}_attr() From: Dan Williams To: linux-nvdimm@lists.01.org Date: Thu, 08 Jun 2017 22:27:44 -0700 Message-ID: <149698606405.12023.3409783083697026090.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.17.1-9-g687f MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Virus-Scanned: ClamAV using ClamSMTP There are occasions where it would be good to know the difference between a sysfs attribute failing to be accessed because we could not open versus could not read/write. Signed-off-by: Dan Williams --- util/sysfs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/util/sysfs.c b/util/sysfs.c index 31d1a898eba2..7905455890dc 100644 --- a/util/sysfs.c +++ b/util/sysfs.c @@ -34,13 +34,13 @@ int __sysfs_read_attr(struct log_ctx *ctx, const char *path, char *buf) if (fd < 0) { log_dbg(ctx, "failed to open %s: %s\n", path, strerror(errno)); - return -1; + return -ENOENT; } n = read(fd, buf, SYSFS_ATTR_SIZE); close(fd); if (n < 0 || n >= SYSFS_ATTR_SIZE) { log_dbg(ctx, "failed to read %s: %s\n", path, strerror(errno)); - return -1; + return -EIO; } buf[n] = 0; if (n && buf[n-1] == '\n') @@ -56,7 +56,7 @@ static int write_attr(struct log_ctx *ctx, const char *path, if (fd < 0) { log_dbg(ctx, "failed to open %s: %s\n", path, strerror(errno)); - return -1; + return -ENOENT; } n = write(fd, buf, len); close(fd); @@ -64,7 +64,7 @@ static int write_attr(struct log_ctx *ctx, const char *path, if (!quiet) log_dbg(ctx, "failed to write %s to %s: %s\n", buf, path, strerror(errno)); - return -1; + return -EIO; } return 0; }