| Message ID | 151087814337.28320.4937088593350611062.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | fe4b805ee235 |
| Headers | show |
Dan Williams <dan.j.williams@intel.com> writes: > When we generate the spec file we're already teaching it the version > number so we don't need to create custom echo line each time. > > Reported-by: Jeff Moyer <jmoyer@redhat.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> LGTM Reviewed-by: Jeff Moyer <jmoyer@redhat.com> > --- > ndctl.spec.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ndctl.spec.in b/ndctl.spec.in > index 4aa133dd70aa..fa60518e43a9 100644 > --- a/ndctl.spec.in > +++ b/ndctl.spec.in > @@ -91,7 +91,7 @@ control API for these devices. > %setup -q ndctl-%{version} > > %build > -echo "VERSION" > version > +echo %{version} > version > ./autogen.sh > %ifarch x86_64 > %configure --disable-static --enable-local --disable-silent-rules --with-libpmem
diff --git a/ndctl.spec.in b/ndctl.spec.in index 4aa133dd70aa..fa60518e43a9 100644 --- a/ndctl.spec.in +++ b/ndctl.spec.in @@ -91,7 +91,7 @@ control API for these devices. %setup -q ndctl-%{version} %build -echo "VERSION" > version +echo %{version} > version ./autogen.sh %ifarch x86_64 %configure --disable-static --enable-local --disable-silent-rules --with-libpmem
When we generate the spec file we're already teaching it the version number so we don't need to create custom echo line each time. Reported-by: Jeff Moyer <jmoyer@redhat.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- ndctl.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)