From patchwork Fri Feb 23 06:59:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Williams X-Patchwork-Id: 10236949 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 94303602DC for ; Fri, 23 Feb 2018 07:08:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8DF7328FDF for ; Fri, 23 Feb 2018 07:08:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 801BF29012; Fri, 23 Feb 2018 07:08:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 220C529006 for ; Fri, 23 Feb 2018 07:08:24 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 3C974223230E2; Thu, 22 Feb 2018 23:02:23 -0800 (PST) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=dan.j.williams@intel.com; receiver=linux-nvdimm@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6D43C21FD73D9 for ; Thu, 22 Feb 2018 23:02:21 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Feb 2018 23:08:22 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,382,1515484800"; d="scan'208";a="19716927" Received: from dwillia2-desk3.jf.intel.com (HELO dwillia2-desk3.amr.corp.intel.com) ([10.54.39.16]) by orsmga007.jf.intel.com with ESMTP; 22 Feb 2018 23:08:22 -0800 Subject: [ndctl PATCH] ndctl, test: skip btt-pad compat test on pre-4K capable kernels From: Dan Williams To: linux-nvdimm@lists.01.org Date: Thu, 22 Feb 2018 22:59:17 -0800 Message-ID: <151936915701.18166.11705045442243684598.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: StGit/0.17.1-9-g687f MIME-Version: 1.0 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Virus-Scanned: ClamAV using ClamSMTP Prior to the introduction of v1.2 namespace labels it was not possible to specify a pmem namespace with a 4K sector size. Skip this test when that namespace creation attempt fails. Cc: Vishal Verma Signed-off-by: Dan Williams Reviewed-by: Ross Zwisler --- test/btt-pad-compat.sh | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/test/btt-pad-compat.sh b/test/btt-pad-compat.sh index a157c589460e..b2e395de2297 100755 --- a/test/btt-pad-compat.sh +++ b/test/btt-pad-compat.sh @@ -136,8 +136,12 @@ copy_xxd_img() create_oldfmt_ns() { - # create null-uuid namespace + # create null-uuid namespace, note that this requires a kernel + # that supports a raw namespace with a 4K sector size, prior to + # v4.13 raw namespaces are limited to 512-byte sector size. + rc=77 json=$($ndctl create-namespace -b "$bus" -s 64M -t pmem -m raw -l 4096 -u 00000000-0000-0000-0000-000000000000) + rc=1 eval "$(echo "$json" | sed -e "$json2var")" [ -n "$dev" ] || err "$LINENO" 2 [ -n "$size" ] || err "$LINENO" 2