| Message ID | 154456575434.852018.13818918249999253002.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | acpi/nfit/intel: Remove zero initialization in security command payloads | expand |
On 12/11/18 3:02 PM, Dan Williams wrote: > C99 struct initialization already zeroes all other fields if any one > field is initialized. > > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Thanks. I missed those. Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/acpi/nfit/intel.c | 13 ------------- > 1 file changed, 13 deletions(-) > > diff --git a/drivers/acpi/nfit/intel.c b/drivers/acpi/nfit/intel.c > index 09317ea23e72..6d5eb4b239a0 100644 > --- a/drivers/acpi/nfit/intel.c > +++ b/drivers/acpi/nfit/intel.c > @@ -198,9 +198,6 @@ static int intel_security_disable(struct nvdimm *nvdimm, > .nd_size_out = ND_INTEL_STATUS_SIZE, > .nd_fw_size = ND_INTEL_STATUS_SIZE, > }, > - .cmd = { > - .status = 0, > - }, > }; > > if (!test_bit(NVDIMM_INTEL_DISABLE_PASSPHRASE, &nfit_mem->dsm_mask)) > @@ -240,9 +237,6 @@ static int intel_security_erase(struct nvdimm *nvdimm, > .nd_size_out = ND_INTEL_STATUS_SIZE, > .nd_fw_size = ND_INTEL_STATUS_SIZE, > }, > - .cmd = { > - .status = 0, > - }, > }; > > if (master) > @@ -292,13 +286,9 @@ static int intel_security_query_overwrite(struct nvdimm *nvdimm) > .pkg = { > .nd_command = NVDIMM_INTEL_QUERY_OVERWRITE, > .nd_family = NVDIMM_FAMILY_INTEL, > - .nd_size_in = 0, > .nd_size_out = ND_INTEL_STATUS_SIZE, > .nd_fw_size = ND_INTEL_STATUS_SIZE, > }, > - .cmd = { > - .status = 0, > - }, > }; > > if (!test_bit(NVDIMM_INTEL_QUERY_OVERWRITE, &nfit_mem->dsm_mask)) > @@ -339,9 +329,6 @@ static int intel_security_overwrite(struct nvdimm *nvdimm, > .nd_size_out = ND_INTEL_STATUS_SIZE, > .nd_fw_size = ND_INTEL_STATUS_SIZE, > }, > - .cmd = { > - .status = 0, > - }, > }; > > if (!test_bit(NVDIMM_INTEL_OVERWRITE, &nfit_mem->dsm_mask)) >
diff --git a/drivers/acpi/nfit/intel.c b/drivers/acpi/nfit/intel.c index 09317ea23e72..6d5eb4b239a0 100644 --- a/drivers/acpi/nfit/intel.c +++ b/drivers/acpi/nfit/intel.c @@ -198,9 +198,6 @@ static int intel_security_disable(struct nvdimm *nvdimm, .nd_size_out = ND_INTEL_STATUS_SIZE, .nd_fw_size = ND_INTEL_STATUS_SIZE, }, - .cmd = { - .status = 0, - }, }; if (!test_bit(NVDIMM_INTEL_DISABLE_PASSPHRASE, &nfit_mem->dsm_mask)) @@ -240,9 +237,6 @@ static int intel_security_erase(struct nvdimm *nvdimm, .nd_size_out = ND_INTEL_STATUS_SIZE, .nd_fw_size = ND_INTEL_STATUS_SIZE, }, - .cmd = { - .status = 0, - }, }; if (master) @@ -292,13 +286,9 @@ static int intel_security_query_overwrite(struct nvdimm *nvdimm) .pkg = { .nd_command = NVDIMM_INTEL_QUERY_OVERWRITE, .nd_family = NVDIMM_FAMILY_INTEL, - .nd_size_in = 0, .nd_size_out = ND_INTEL_STATUS_SIZE, .nd_fw_size = ND_INTEL_STATUS_SIZE, }, - .cmd = { - .status = 0, - }, }; if (!test_bit(NVDIMM_INTEL_QUERY_OVERWRITE, &nfit_mem->dsm_mask)) @@ -339,9 +329,6 @@ static int intel_security_overwrite(struct nvdimm *nvdimm, .nd_size_out = ND_INTEL_STATUS_SIZE, .nd_fw_size = ND_INTEL_STATUS_SIZE, }, - .cmd = { - .status = 0, - }, }; if (!test_bit(NVDIMM_INTEL_OVERWRITE, &nfit_mem->dsm_mask))
C99 struct initialization already zeroes all other fields if any one field is initialized. Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- drivers/acpi/nfit/intel.c | 13 ------------- 1 file changed, 13 deletions(-)