diff mbox series

[driver-core,v10,8/9] libnvdimm: Schedule device registration on node local to the device

Message ID 154818238742.18753.12796774960063459729.stgit@ahduyck-desk1.amr.corp.intel.com (mailing list archive)
State Mainlined
Commit af87b9a7863c7bb47f8bd015c0ce4a37d70c5225
Headers show
Series Add NUMA aware async_schedule calls | expand

Commit Message

Alexander Duyck Jan. 22, 2019, 6:39 p.m. UTC
Force the device registration for nvdimm devices to be closer to the actual
device. This is achieved by using either the NUMA node ID of the region, or
of the parent. By doing this we can have everything above the region based
on the region, and everything below the region based on the nvdimm bus.

By guaranteeing NUMA locality I see an improvement of as high as 25% for
per-node init of a system with 12TB of persistent memory.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Alexander Duyck <alexander.h.duyck@linux.intel.com>
 drivers/nvdimm/bus.c |   11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)
diff mbox series


diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
index dca5f7a805cb..7bbff0af29b2 100644
--- a/drivers/nvdimm/bus.c
+++ b/drivers/nvdimm/bus.c
@@ -23,6 +23,7 @@ 
 #include <linux/ndctl.h>
 #include <linux/sched.h>
 #include <linux/slab.h>
+#include <linux/cpu.h>
 #include <linux/fs.h>
 #include <linux/io.h>
 #include <linux/mm.h>
@@ -534,11 +535,15 @@  void __nd_device_register(struct device *dev)
 		set_dev_node(dev, to_nd_region(dev)->numa_node);
 	dev->bus = &nvdimm_bus_type;
-	if (dev->parent)
+	if (dev->parent) {
+		if (dev_to_node(dev) == NUMA_NO_NODE)
+			set_dev_node(dev, dev_to_node(dev->parent));
+	}
-	async_schedule_domain(nd_async_device_register, dev,
-			&nd_async_domain);
+	async_schedule_dev_domain(nd_async_device_register, dev,
+				  &nd_async_domain);
 void nd_device_register(struct device *dev)