diff mbox series

nvdimm: Fix missing error code in btt_read_pg()

Message ID 1622802249-45353-1-git-send-email-jiapeng.chong@linux.alibaba.com (mailing list archive)
State New
Headers show
Series nvdimm: Fix missing error code in btt_read_pg() | expand

Commit Message

Jiapeng Chong June 4, 2021, 10:24 a.m. UTC
When we failed to get e_flag, the return value of btt_read_pg() is -EIO,
but when we failed to get t_flag, the return value of the btt_read_pg()
is '0' above. So We set ret to -EIO in this case.

Eliminate the follow smatch warning:

drivers/nvdimm/btt.c:1234 btt_read_pg() warn: missing error code 'ret'.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
 drivers/nvdimm/btt.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series


diff --git a/drivers/nvdimm/btt.c b/drivers/nvdimm/btt.c
index 92dec49..44f5b666 100644
--- a/drivers/nvdimm/btt.c
+++ b/drivers/nvdimm/btt.c
@@ -1231,6 +1231,7 @@  static int btt_read_pg(struct btt *btt, struct bio_integrity_payload *bip,
 			if (t_flag) {
 				zero_fill_data(page, off, cur_len);
+				ret = -EIO;
 				goto out_lane;