diff mbox series

[v3,34/40] cxl/core: Move target_list out of base decoder attributes

Message ID 164298430100.3018233.4715072508880290970.stgit@dwillia2-desk3.amr.corp.intel.com (mailing list archive)
State Accepted
Commit 8aea0ef19fde030f983aba0e7ec5bcf10880a6fe
Headers show
Series CXL.mem Topology Discovery and Hotplug Support | expand

Commit Message

Dan Williams Jan. 24, 2022, 12:31 a.m. UTC
In preparation for introducing endpoint decoder objects, move the
target_list attribute out of the common set since it has no meaning for
endpoint decoders.

Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/cxl/core/port.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jonathan Cameron Jan. 31, 2022, 6:45 p.m. UTC | #1
On Sun, 23 Jan 2022 16:31:41 -0800
Dan Williams <dan.j.williams@intel.com> wrote:

> In preparation for introducing endpoint decoder objects, move the
> target_list attribute out of the common set since it has no meaning for
> endpoint decoders.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  drivers/cxl/core/port.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> index 13027fc2441d..39ce0fa7b285 100644
> --- a/drivers/cxl/core/port.c
> +++ b/drivers/cxl/core/port.c
> @@ -186,7 +186,6 @@ static struct attribute *cxl_decoder_base_attrs[] = {
>  	&dev_attr_start.attr,
>  	&dev_attr_size.attr,
>  	&dev_attr_locked.attr,
> -	&dev_attr_target_list.attr,
>  	NULL,
>  };
>  
> @@ -199,6 +198,7 @@ static struct attribute *cxl_decoder_root_attrs[] = {
>  	&dev_attr_cap_ram.attr,
>  	&dev_attr_cap_type2.attr,
>  	&dev_attr_cap_type3.attr,
> +	&dev_attr_target_list.attr,
>  	NULL,
>  };
>  
> @@ -215,6 +215,7 @@ static const struct attribute_group *cxl_decoder_root_attribute_groups[] = {
>  
>  static struct attribute *cxl_decoder_switch_attrs[] = {
>  	&dev_attr_target_type.attr,
> +	&dev_attr_target_list.attr,
>  	NULL,
>  };
>  
>
Ben Widawsky Feb. 1, 2022, 5:45 p.m. UTC | #2
On 22-01-23 16:31:41, Dan Williams wrote:
> In preparation for introducing endpoint decoder objects, move the
> target_list attribute out of the common set since it has no meaning for
> endpoint decoders.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>

Could add DPA skip at some point to replace it.

Reviewed-by: Ben Widawsky <ben.widawsky@intel.com>

[snip]
diff mbox series

Patch

diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
index 13027fc2441d..39ce0fa7b285 100644
--- a/drivers/cxl/core/port.c
+++ b/drivers/cxl/core/port.c
@@ -186,7 +186,6 @@  static struct attribute *cxl_decoder_base_attrs[] = {
 	&dev_attr_start.attr,
 	&dev_attr_size.attr,
 	&dev_attr_locked.attr,
-	&dev_attr_target_list.attr,
 	NULL,
 };
 
@@ -199,6 +198,7 @@  static struct attribute *cxl_decoder_root_attrs[] = {
 	&dev_attr_cap_ram.attr,
 	&dev_attr_cap_type2.attr,
 	&dev_attr_cap_type3.attr,
+	&dev_attr_target_list.attr,
 	NULL,
 };
 
@@ -215,6 +215,7 @@  static const struct attribute_group *cxl_decoder_root_attribute_groups[] = {
 
 static struct attribute *cxl_decoder_switch_attrs[] = {
 	&dev_attr_target_type.attr,
+	&dev_attr_target_list.attr,
 	NULL,
 };