[ndctl,v2] ndctl: Fix the NDCTL_TIMEOUT environment variable parsing

Commit Message

Shivaprasad G Bhat Nov. 4, 2022, 7:31 a.m. UTC

The strtoul(x, y, size) returns empty string on y when the x is "only"
number with no other suffix strings. The code is checking if !null
instead of comparing with empty string.

Signed-off-by: Shivaprasad G Bhat <[e-mail]>
---
Changelog:
Since v1:
Link: https://lore.kernel.org/all/166373424779.231228.12814077203589935658.stgit@LAPTOP-TBQTPII8/
* Avoid using strcmp

 ndctl/lib/libndctl.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/ndctl/lib/libndctl.c b/ndctl/lib/libndctl.c
index ad54f06..77c31ab 100644
--- a/ndctl/lib/libndctl.c
+++ b/ndctl/lib/libndctl.c
@@ -334,7 +334,7 @@  NDCTL_EXPORT int ndctl_new(struct ndctl_ctx **ctx)
 		char *end;
 
 		tmo = strtoul(env, &end, 0);
-		if (tmo < ULONG_MAX && !end)
+		if (tmo < ULONG_MAX && !*end)
 			c->timeout = tmo;
 		dbg(c, "timeout = %ld\n", tmo);
 	}