| Message ID | 170191437889.426826.15528612879942432918.stgit@dwillia2-xfh.jf.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ce2fa3e597dde3297c25d27aa6b0a30035583af7 |
| Delegated to: | Ira Weiny |
| Headers | show |
| Series | tools/testing/nvdimm: Add compile-test coverage for ndtest | expand |
Dan Williams wrote: > Greg lamented: > "Ick, sorry about that, obviously this test isn't actually built by any > bots :(" > > A quick and dirty way to prevent this problem going forward is to always > compile ndtest.ko whenever nfit_test is built. While this still does not > expose the test code to any of the known build bots, it at least makes > it the case that anyone that runs the x86 tests also compiles the > powerpc test. > > I.e. the Intel NVDIMM maintainers are less likely to fall into this hole > in the future. > > Link: http://lore.kernel.org/r/2023112729-aids-drainable-5744@gregkh > Cc: Greg KH <gregkh@linuxfoundation.org> > Cc: Yi Zhang <yi.zhang@redhat.com> > Cc: Dave Jiang <dave.jiang@intel.com> > Cc: Ira Weiny <ira.weiny@intel.com> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
On 12/6/23 18:59, Dan Williams wrote: > Greg lamented: > "Ick, sorry about that, obviously this test isn't actually built by any > bots :(" > > A quick and dirty way to prevent this problem going forward is to always > compile ndtest.ko whenever nfit_test is built. While this still does not > expose the test code to any of the known build bots, it at least makes > it the case that anyone that runs the x86 tests also compiles the > powerpc test. > > I.e. the Intel NVDIMM maintainers are less likely to fall into this hole > in the future. > > Link: http://lore.kernel.org/r/2023112729-aids-drainable-5744@gregkh > Cc: Greg KH <gregkh@linuxfoundation.org> > Cc: Yi Zhang <yi.zhang@redhat.com> > Cc: Dave Jiang <dave.jiang@intel.com> > Cc: Ira Weiny <ira.weiny@intel.com> > Signed-off-by: Dan Williams <dan.j.williams@intel.com> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > tools/testing/nvdimm/test/Kbuild | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/nvdimm/test/Kbuild b/tools/testing/nvdimm/test/Kbuild > index 197bcb2b7f35..003d48f5f24f 100644 > --- a/tools/testing/nvdimm/test/Kbuild > +++ b/tools/testing/nvdimm/test/Kbuild > @@ -7,6 +7,7 @@ obj-m += nfit_test_iomap.o > > ifeq ($(CONFIG_ACPI_NFIT),m) > nfit_test-y := nfit.o > + obj-m += ndtest.o > else > nfit_test-y := ndtest.o > endif >
diff --git a/tools/testing/nvdimm/test/Kbuild b/tools/testing/nvdimm/test/Kbuild index 197bcb2b7f35..003d48f5f24f 100644 --- a/tools/testing/nvdimm/test/Kbuild +++ b/tools/testing/nvdimm/test/Kbuild @@ -7,6 +7,7 @@ obj-m += nfit_test_iomap.o ifeq ($(CONFIG_ACPI_NFIT),m) nfit_test-y := nfit.o + obj-m += ndtest.o else nfit_test-y := ndtest.o endif
Greg lamented: "Ick, sorry about that, obviously this test isn't actually built by any bots :(" A quick and dirty way to prevent this problem going forward is to always compile ndtest.ko whenever nfit_test is built. While this still does not expose the test code to any of the known build bots, it at least makes it the case that anyone that runs the x86 tests also compiles the powerpc test. I.e. the Intel NVDIMM maintainers are less likely to fall into this hole in the future. Link: http://lore.kernel.org/r/2023112729-aids-drainable-5744@gregkh Cc: Greg KH <gregkh@linuxfoundation.org> Cc: Yi Zhang <yi.zhang@redhat.com> Cc: Dave Jiang <dave.jiang@intel.com> Cc: Ira Weiny <ira.weiny@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> --- tools/testing/nvdimm/test/Kbuild | 1 + 1 file changed, 1 insertion(+)