diff mbox

libnvdimm: fix smart data retrieval

Message ID 20160407005344.30117.84197.stgit@dwillia2-desk3.jf.intel.com (mailing list archive)
State Accepted
Commit 211291126698
Headers show

Commit Message

Dan Williams April 7, 2016, 12:53 a.m. UTC
It appears that smart data retrieval has been broken the since the
initial implementation.  Fix the payload size to be 128-bytes per the
specification.

Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/nvdimm/bus.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Johannes Thumshirn April 7, 2016, 8:22 a.m. UTC | #1
On Mittwoch, 6. April 2016 17:53:44 CEST Dan Williams wrote:
> It appears that smart data retrieval has been broken the since the
> initial implementation.  Fix the payload size to be 128-bytes per the
> specification.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
Good catch,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
diff mbox

Patch

diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
index fc82743aefb6..19f822d7f652 100644
--- a/drivers/nvdimm/bus.c
+++ b/drivers/nvdimm/bus.c
@@ -407,7 +407,7 @@  static const struct nd_cmd_desc __nd_cmd_dimm_descs[] = {
 	[ND_CMD_IMPLEMENTED] = { },
 	[ND_CMD_SMART] = {
 		.out_num = 2,
-		.out_sizes = { 4, 8, },
+		.out_sizes = { 4, 128, },
 	},
 	[ND_CMD_SMART_THRESHOLD] = {
 		.out_num = 2,