| Message ID | 20160623095204.32167-1-jthumshirn@suse.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8729bdea829e |
| Headers | show |
On Thu, Jun 23, 2016 at 11:52:04AM +0200, Johannes Thumshirn wrote: > Initialize struct blk_integrity with 0 as blk_integrity_register() takes the > then unitialized struct blk_integrity::flags and ORs it to the resulting block > integrity structure. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> > --- > drivers/nvdimm/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c > index be89764..32e4fe2 100644 > --- a/drivers/nvdimm/core.c > +++ b/drivers/nvdimm/core.c > @@ -601,7 +601,8 @@ int nd_integrity_init(struct gendisk *disk, unsigned long meta_size) > if (meta_size == 0) > return 0; > > - bi.profile = NULL; > + memset(&bi, 0, sizeof(bi)); > + > bi.tuple_size = meta_size; > bi.tag_size = meta_size; > > -- > 2.8.4 > Dan, have you seen this one? I've found it in patchwork but didn't get a mail on the list either. Thanks, Johannes
On Tue, Jul 5, 2016 at 2:02 AM, Johannes Thumshirn <jthumshirn@suse.de> wrote: > On Thu, Jun 23, 2016 at 11:52:04AM +0200, Johannes Thumshirn wrote: >> Initialize struct blk_integrity with 0 as blk_integrity_register() takes the >> then unitialized struct blk_integrity::flags and ORs it to the resulting block >> integrity structure. >> >> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> >> --- >> drivers/nvdimm/core.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c >> index be89764..32e4fe2 100644 >> --- a/drivers/nvdimm/core.c >> +++ b/drivers/nvdimm/core.c >> @@ -601,7 +601,8 @@ int nd_integrity_init(struct gendisk *disk, unsigned long meta_size) >> if (meta_size == 0) >> return 0; >> >> - bi.profile = NULL; >> + memset(&bi, 0, sizeof(bi)); >> + >> bi.tuple_size = meta_size; >> bi.tag_size = meta_size; >> >> -- >> 2.8.4 >> > > Dan, > > have you seen this one? I've found it in patchwork but didn't get a mail on > the list either. Thanks for the nudge, I missed this. Applied now.
diff --git a/drivers/nvdimm/core.c b/drivers/nvdimm/core.c index be89764..32e4fe2 100644 --- a/drivers/nvdimm/core.c +++ b/drivers/nvdimm/core.c @@ -601,7 +601,8 @@ int nd_integrity_init(struct gendisk *disk, unsigned long meta_size) if (meta_size == 0) return 0; - bi.profile = NULL; + memset(&bi, 0, sizeof(bi)); + bi.tuple_size = meta_size; bi.tag_size = meta_size;
Initialize struct blk_integrity with 0 as blk_integrity_register() takes the then unitialized struct blk_integrity::flags and ORs it to the resulting block integrity structure. Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- drivers/nvdimm/core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)