Message ID | 20161126191804.21349-1-nicolas.iooss_linux@m4x.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Sat, Nov 26, 2016 at 08:18:04PM +0100, Nicolas Iooss wrote: > In create_namespace_blk(), the local variable "name" is defined as an > array of NSLABEL_NAME_LEN pointers: > > char *name[NSLABEL_NAME_LEN]; > > This variable is then used in calls to memcpy() and kmemdup() as if it > were char[NSLABEL_NAME_LEN]. Remove the star in the variable definition > to makes it look right. > > Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> Yep, nice catch. Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
diff --git a/drivers/nvdimm/namespace_devs.c b/drivers/nvdimm/namespace_devs.c index abe5c6bc756c..7569ba70cdde 100644 --- a/drivers/nvdimm/namespace_devs.c +++ b/drivers/nvdimm/namespace_devs.c @@ -1997,7 +1997,7 @@ struct device *create_namespace_blk(struct nd_region *nd_region, struct nd_mapping *nd_mapping = &nd_region->mapping[0]; struct nvdimm_drvdata *ndd = to_ndd(nd_mapping); struct nd_namespace_blk *nsblk; - char *name[NSLABEL_NAME_LEN]; + char name[NSLABEL_NAME_LEN]; struct device *dev = NULL; struct resource *res;
In create_namespace_blk(), the local variable "name" is defined as an array of NSLABEL_NAME_LEN pointers: char *name[NSLABEL_NAME_LEN]; This variable is then used in calls to memcpy() and kmemdup() as if it were char[NSLABEL_NAME_LEN]. Remove the star in the variable definition to makes it look right. Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@m4x.org> --- drivers/nvdimm/namespace_devs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)