[ndctl,0/7] introduce 'daxctl list', and 'ndctl list' updates

Commit Message

Verma, Vishal L Jan. 9, 2017, 9:56 p.m. UTC

On 01/06, Dan Williams wrote:
> * The 'ndctl list' command awkwardly prints out all the corresponding
>   device-dax information when a namespace is in 'dax' mode. Conversely if
>   someone is only interested in listing device-dax information they need to
>   contend with libnvdimm data.
> 
>   Introduce a separate daxctl utility with its own 'list' command for this
>   purpose, and make the listing of device-dax data through 'ndctl list'
>   optional (new --device-dax option).

the 'rpmbuild' script was failing as the new daxctl utility wasn't
included in %files in the spec. The following patch fixes that.

8<-----

From d26a582b4ae9e69a22e52908a5d4bbae0a79717f Mon Sep 17 00:00:00 2001
From: Vishal Verma <[e-mail]>
Date: Mon, 9 Jan 2017 14:52:34 -0700
Subject: [PATCH] spec: add the new daxctl binary to the spec file

The missing binary was triggering the "installed but unpackaged file
found" check for rpmbuild. Add daxctl to the %files section as we do
want it to be packaged.

Signed-off-by: Vishal Verma <[e-mail]>
---
 ndctl.spec.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Dan Williams Jan. 9, 2017, 10 p.m. UTC | #1

On Mon, Jan 9, 2017 at 1:56 PM, Vishal Verma <[e-mail]> wrote:
> On 01/06, Dan Williams wrote:
>> * The 'ndctl list' command awkwardly prints out all the corresponding
>>   device-dax information when a namespace is in 'dax' mode. Conversely if
>>   someone is only interested in listing device-dax information they need to
>>   contend with libnvdimm data.
>>
>>   Introduce a separate daxctl utility with its own 'list' command for this
>>   purpose, and make the listing of device-dax data through 'ndctl list'
>>   optional (new --device-dax option).
>
> the 'rpmbuild' script was failing as the new daxctl utility wasn't
> included in %files in the spec. The following patch fixes that.
>
> 8<-----
>
> From d26a582b4ae9e69a22e52908a5d4bbae0a79717f Mon Sep 17 00:00:00 2001
> From: Vishal Verma <[e-mail]>
> Date: Mon, 9 Jan 2017 14:52:34 -0700
> Subject: [PATCH] spec: add the new daxctl binary to the spec file
>
> The missing binary was triggering the "installed but unpackaged file
> found" check for rpmbuild. Add daxctl to the %files section as we do
> want it to be packaged.

Yes, we do want it packaged, but in it's own rpm. I have patch to add
that as well as a daxctl man page.

Verma, Vishal L Jan. 9, 2017, 10:05 p.m. UTC | #2

On Mon, 2017-01-09 at 14:00 -0800, Dan Williams wrote:
> On Mon, Jan 9, 2017 at 1:56 PM, Vishal Verma <[e-mail]

> > wrote:

> > On 01/06, Dan Williams wrote:

> > > * The 'ndctl list' command awkwardly prints out all the

> > > corresponding

> > >   device-dax information when a namespace is in 'dax' mode.

> > > Conversely if

> > >   someone is only interested in listing device-dax information

> > > they need to

> > >   contend with libnvdimm data.

> > > 

> > >   Introduce a separate daxctl utility with its own 'list' command

> > > for this

> > >   purpose, and make the listing of device-dax data through 'ndctl

> > > list'

> > >   optional (new --device-dax option).

> > 

> > the 'rpmbuild' script was failing as the new daxctl utility wasn't

> > included in %files in the spec. The following patch fixes that.

> > 

> > 8<-----

> > 

> > From d26a582b4ae9e69a22e52908a5d4bbae0a79717f Mon Sep 17 00:00:00

> > 2001

> > From: Vishal Verma <[e-mail]>

> > Date: Mon, 9 Jan 2017 14:52:34 -0700

> > Subject: [PATCH] spec: add the new daxctl binary to the spec file

> > 

> > The missing binary was triggering the "installed but unpackaged file

> > found" check for rpmbuild. Add daxctl to the %files section as we do

> > want it to be packaged.

> 

> Yes, we do want it packaged, but in it's own rpm. I have patch to add

> that as well as a daxctl man page.


Ah ok - I thought it would just get installed as a part of the ndctl
rpm.

Patch

diff --git a/ndctl.spec.in b/ndctl.spec.in
index 6453edd..4a22597 100644
--- a/ndctl.spec.in
+++ b/ndctl.spec.in
@@ -114,6 +114,7 @@  make check
 %defattr(-,root,root)
 %license util/COPYING licenses/BSD-MIT licenses/CC0
 %{_bindir}/ndctl
+%{_bindir}/daxctl
 %{_mandir}/man1/*
 %{bashcompdir}/