From patchwork Mon Jan 9 21:56:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Verma, Vishal L" X-Patchwork-Id: 9506007 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5504A60757 for ; Mon, 9 Jan 2017 21:57:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 47AF32840E for ; Mon, 9 Jan 2017 21:57:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 399EF2849C; Mon, 9 Jan 2017 21:57:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id E06022840E for ; Mon, 9 Jan 2017 21:57:45 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 6BDFB81935; Mon, 9 Jan 2017 13:57:45 -0800 (PST) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D5D428178D for ; Mon, 9 Jan 2017 13:57:43 -0800 (PST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP; 09 Jan 2017 13:57:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos; i="5.33,341,1477983600"; d="scan'208"; a="1110219321" Received: from omniknight.lm.intel.com ([10.232.112.53]) by fmsmga002.fm.intel.com with ESMTP; 09 Jan 2017 13:57:43 -0800 Date: Mon, 9 Jan 2017 14:56:37 -0700 From: Vishal Verma To: Dan Williams Subject: Re: [ndctl PATCH 0/7] introduce 'daxctl list', and 'ndctl list' updates Message-ID: <20170109215636.GA5330@omniknight.lm.intel.com> References: <148375332631.38836.5735184615585844571.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <148375332631.38836.5735184615585844571.stgit@dwillia2-desk3.amr.corp.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-nvdimm@lists.01.org Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Virus-Scanned: ClamAV using ClamSMTP On 01/06, Dan Williams wrote: > * The 'ndctl list' command awkwardly prints out all the corresponding > device-dax information when a namespace is in 'dax' mode. Conversely if > someone is only interested in listing device-dax information they need to > contend with libnvdimm data. > > Introduce a separate daxctl utility with its own 'list' command for this > purpose, and make the listing of device-dax data through 'ndctl list' > optional (new --device-dax option). the 'rpmbuild' script was failing as the new daxctl utility wasn't included in %files in the spec. The following patch fixes that. 8<----- From d26a582b4ae9e69a22e52908a5d4bbae0a79717f Mon Sep 17 00:00:00 2001 From: Vishal Verma Date: Mon, 9 Jan 2017 14:52:34 -0700 Subject: [PATCH] spec: add the new daxctl binary to the spec file The missing binary was triggering the "installed but unpackaged file found" check for rpmbuild. Add daxctl to the %files section as we do want it to be packaged. Signed-off-by: Vishal Verma --- ndctl.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/ndctl.spec.in b/ndctl.spec.in index 6453edd..4a22597 100644 --- a/ndctl.spec.in +++ b/ndctl.spec.in @@ -114,6 +114,7 @@ make check %defattr(-,root,root) %license util/COPYING licenses/BSD-MIT licenses/CC0 %{_bindir}/ndctl +%{_bindir}/daxctl %{_mandir}/man1/* %{bashcompdir}/