From patchwork Wed Mar 29 17:36:16 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Verma, Vishal L" X-Patchwork-Id: 9652041 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 5626E602C8 for ; Wed, 29 Mar 2017 17:37:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4DBD826223 for ; Wed, 29 Mar 2017 17:37:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 40323284F7; Wed, 29 Mar 2017 17:37:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id EE2B226223 for ; Wed, 29 Mar 2017 17:37:44 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 170A42050AAF2; Wed, 29 Mar 2017 10:37:44 -0700 (PDT) X-Original-To: linux-nvdimm@lists.01.org Delivered-To: linux-nvdimm@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5D7822050AAEC for ; Wed, 29 Mar 2017 10:37:43 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP; 29 Mar 2017 10:37:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,242,1486454400"; d="scan'208";a="839743820" Received: from omniknight.lm.intel.com ([10.232.112.53]) by FMSMGA003.fm.intel.com with ESMTP; 29 Mar 2017 10:37:42 -0700 From: Vishal Verma To: Subject: [ndctl PATCH] completion: updates for file name completion Date: Wed, 29 Mar 2017 11:36:16 -0600 Message-Id: <20170329173616.7571-1-vishal.l.verma@intel.com> X-Mailer: git-send-email 2.9.3 X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Virus-Scanned: ClamAV using ClamSMTP Add file name completion for the --input and --output arguments of read-labels and the new write-labels commands. Signed-off-by: Vishal Verma --- contrib/ndctl | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/contrib/ndctl b/contrib/ndctl index c97adcc..076423f 100755 --- a/contrib/ndctl +++ b/contrib/ndctl @@ -91,7 +91,7 @@ __ndctlcomp() COMPREPLY=( $( compgen -W "$1" -- "$2" ) ) for cword in "${COMPREPLY[@]}"; do - if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace) ]]; then + if [[ "$cword" == @(--bus|--region|--type|--mode|--size|--dimm|--reconfig|--uuid|--name|--sector-size|--map|--namespace|--input|--output) ]]; then COMPREPLY[$i]="${cword}=" else COMPREPLY[$i]="${cword} " @@ -132,6 +132,11 @@ __ndctl_get_dimms() echo "$(ndctl list $opts | grep -E "^\s*\"dev\":" | cut -d\" -f4)" } +__ndctl_file_comp() +{ + local cur="$1" + _filedir +} __ndctl_comp_options() { local cur=$1 @@ -171,6 +176,12 @@ __ndctl_comp_options() --map) opts="mem dev" ;; + --output) + ;& + --input) + __ndctl_file_comp "${cur##*=}" + return + ;; *) return ;; @@ -215,6 +226,8 @@ __ndctl_comp_non_option_args() ;& read-labels) ;& + write-labels) + ;& zero-labels) opts="$(__ndctl_get_dimms -i) all" ;;