| Message ID | 20180427215314.23168-1-ross.zwisler@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Apr 30, 2018 at 12:38:58PM +0100, Stefan Hajnoczi wrote: > On Fri, Apr 27, 2018 at 03:53:12PM -0600, Ross Zwisler wrote: > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> > > Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") > > Cc: Haozhong Zhang <haozhong.zhang@intel.com> > > Cc: Michael S. Tsirkin <mst@redhat.com> > > Cc: Stefan Hajnoczi <stefanha@redhat.com> > > --- > > hw/mem/nvdimm.c | 2 +- > > include/hw/mem/nvdimm.h | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Thank you for the review. This is my first QEMU submission - do I need to do anything else to get this merged (create a pull request somewhere), or do I just wait for a maintainer to pull it in? Thanks, - Ross
On Fri, 27 Apr 2018 15:53:12 -0600 Ross Zwisler <ross.zwisler@linux.intel.com> wrote: > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> > Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") > Cc: Haozhong Zhang <haozhong.zhang@intel.com> > Cc: Michael S. Tsirkin <mst@redhat.com> > Cc: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > hw/mem/nvdimm.c | 2 +- > include/hw/mem/nvdimm.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c > index acb656b672..4087aca25e 100644 > --- a/hw/mem/nvdimm.c > +++ b/hw/mem/nvdimm.c > @@ -89,7 +89,7 @@ static void nvdimm_set_unarmed(Object *obj, bool value, Error **errp) > > static void nvdimm_init(Object *obj) > { > - object_property_add(obj, NVDIMM_LABLE_SIZE_PROP, "int", > + object_property_add(obj, NVDIMM_LABEL_SIZE_PROP, "int", > nvdimm_get_label_size, nvdimm_set_label_size, NULL, > NULL, NULL); > object_property_add_bool(obj, NVDIMM_UNARMED_PROP, > diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h > index 7fd87c4e1c..74c60332e1 100644 > --- a/include/hw/mem/nvdimm.h > +++ b/include/hw/mem/nvdimm.h > @@ -48,7 +48,7 @@ > #define NVDIMM_GET_CLASS(obj) OBJECT_GET_CLASS(NVDIMMClass, (obj), \ > TYPE_NVDIMM) > > -#define NVDIMM_LABLE_SIZE_PROP "label-size" > +#define NVDIMM_LABEL_SIZE_PROP "label-size" > #define NVDIMM_UNARMED_PROP "unarmed" > > struct NVDIMMDevice {
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c index acb656b672..4087aca25e 100644 --- a/hw/mem/nvdimm.c +++ b/hw/mem/nvdimm.c @@ -89,7 +89,7 @@ static void nvdimm_set_unarmed(Object *obj, bool value, Error **errp) static void nvdimm_init(Object *obj) { - object_property_add(obj, NVDIMM_LABLE_SIZE_PROP, "int", + object_property_add(obj, NVDIMM_LABEL_SIZE_PROP, "int", nvdimm_get_label_size, nvdimm_set_label_size, NULL, NULL, NULL); object_property_add_bool(obj, NVDIMM_UNARMED_PROP, diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h index 7fd87c4e1c..74c60332e1 100644 --- a/include/hw/mem/nvdimm.h +++ b/include/hw/mem/nvdimm.h @@ -48,7 +48,7 @@ #define NVDIMM_GET_CLASS(obj) OBJECT_GET_CLASS(NVDIMMClass, (obj), \ TYPE_NVDIMM) -#define NVDIMM_LABLE_SIZE_PROP "label-size" +#define NVDIMM_LABEL_SIZE_PROP "label-size" #define NVDIMM_UNARMED_PROP "unarmed" struct NVDIMMDevice {
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"") Cc: Haozhong Zhang <haozhong.zhang@intel.com> Cc: Michael S. Tsirkin <mst@redhat.com> Cc: Stefan Hajnoczi <stefanha@redhat.com> --- hw/mem/nvdimm.c | 2 +- include/hw/mem/nvdimm.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)