| Message ID | 20180521163203.26590-3-ross.zwisler@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/21/2018 11:32 AM, Ross Zwisler wrote: > After a "make check" we end up with the following: > > $ git status > On branch master > Your branch is up-to-date with 'origin/master'. > > Untracked files: > (use "git add <file>..." to include in what will be committed) > > tests/test-block-backend > > nothing added to commit but untracked files present (use "git add" to track) > > Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> > Fixes: commit ad0df3e0fdac ("block: test blk_aio_flush() with blk->root == NULL") > Cc: Kevin Wolf <kwolf@redhat.com> > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Eric Blake <eblake@redhat.com> > > diff --git a/tests/.gitignore b/tests/.gitignore > index fb62d2299b..2bc61a9a58 100644 > --- a/tests/.gitignore > +++ b/tests/.gitignore > @@ -21,6 +21,7 @@ test-base64 > test-bdrv-drain > test-bitops > test-bitcnt > +test-block-backend > test-blockjob > test-blockjob-txn > test-bufferiszero >
On 05/21/2018 01:41 PM, Eric Blake wrote: > On 05/21/2018 11:32 AM, Ross Zwisler wrote: >> After a "make check" we end up with the following: >> >> $ git status >> On branch master >> Your branch is up-to-date with 'origin/master'. >> >> Untracked files: >> (use "git add <file>..." to include in what will be committed) >> >> tests/test-block-backend >> >> nothing added to commit but untracked files present (use "git add" to >> track) >> >> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> >> Fixes: commit ad0df3e0fdac ("block: test blk_aio_flush() with >> blk->root == NULL") >> Cc: Kevin Wolf <kwolf@redhat.com> >> --- >> tests/.gitignore | 1 + >> 1 file changed, 1 insertion(+) > > Reviewed-by: Eric Blake <eblake@redhat.com> > >> >> diff --git a/tests/.gitignore b/tests/.gitignore >> index fb62d2299b..2bc61a9a58 100644 >> --- a/tests/.gitignore >> +++ b/tests/.gitignore >> @@ -21,6 +21,7 @@ test-base64 >> test-bdrv-drain >> test-bitops >> test-bitcnt >> +test-block-backend >> test-blockjob >> test-blockjob-txn >> test-bufferiszero What about using gitignore negated pattern in tests/?
On 05/21/2018 12:32 PM, Philippe Mathieu-Daudé wrote: >>> >>> tests/test-block-backend >>> >>> +test-block-backend >>> test-blockjob >>> test-blockjob-txn >>> test-bufferiszero > > What about using gitignore negated pattern in tests/? Or, what we've threatened to do in the past: rename all unit tests to the pattern *-test instead of test-*, as a suffix is a lot easier to exclude via glob than a prefix. And while we're renaming things, sort tests into separate subdirectories according to whether they are run as part of 'make check-unit' or 'make check-qtest'. But until someone does that work, tweaking the .gitignore for individual tests as they keep getting added is no worse than what we've been doing.
diff --git a/tests/.gitignore b/tests/.gitignore index fb62d2299b..2bc61a9a58 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -21,6 +21,7 @@ test-base64 test-bdrv-drain test-bitops test-bitcnt +test-block-backend test-blockjob test-blockjob-txn test-bufferiszero
After a "make check" we end up with the following: $ git status On branch master Your branch is up-to-date with 'origin/master'. Untracked files: (use "git add <file>..." to include in what will be committed) tests/test-block-backend nothing added to commit but untracked files present (use "git add" to track) Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com> Fixes: commit ad0df3e0fdac ("block: test blk_aio_flush() with blk->root == NULL") Cc: Kevin Wolf <kwolf@redhat.com> --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+)