diff mbox

[ndctl] libndctl: fix the uninject-error API actually injecting errors

Message ID 20180706182841.16869-1-vishal.l.verma@intel.com (mailing list archive)
State New, archived
Headers show

Commit Message

Verma, Vishal L July 6, 2018, 6:28 p.m. UTC
The addition of the v2 APIs introduced a bug when they rerouted the
old APIs to call the new v2 ones. ndctl_namespace_uninject_error()
called ndctl_namespace_inject_error2() instead of
ndctl_namespace_uninject_error2().

Reported-by: Tomasz Rochumski <tomasz.rochumski@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 ndctl/lib/inject.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Dan Williams July 6, 2018, 6:30 p.m. UTC | #1
On Fri, Jul 6, 2018 at 11:28 AM, Vishal Verma <vishal.l.verma@intel.com> wrote:
> The addition of the v2 APIs introduced a bug when they rerouted the
> old APIs to call the new v2 ones. ndctl_namespace_uninject_error()
> called ndctl_namespace_inject_error2() instead of
> ndctl_namespace_uninject_error2().

Acked-by: Dan Williams <dan.j.williams@intel.com>
diff mbox

Patch

diff --git a/ndctl/lib/inject.c b/ndctl/lib/inject.c
index 848f8a9..f9da02d 100644
--- a/ndctl/lib/inject.c
+++ b/ndctl/lib/inject.c
@@ -271,7 +271,7 @@  NDCTL_EXPORT int ndctl_namespace_uninject_error2(struct ndctl_namespace *ndns,
 NDCTL_EXPORT int ndctl_namespace_uninject_error(struct ndctl_namespace *ndns,
 		unsigned long long block, unsigned long long count)
 {
-	return ndctl_namespace_inject_error2(ndns, block, count, 0);
+	return ndctl_namespace_uninject_error2(ndns, block, count, 0);
 }
 
 static int bb_add_record(struct list_head *h, u64 block, u64 count)