| Message ID | 20180801185538.27084-1-msys.mizuma@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ndctl, monitor: Change the fail log priority to err. | expand |
> -----Original Message----- > From: Masayoshi Mizuma [mailto:msys.mizuma@gmail.com] > Sent: Thursday, August 2, 2018 3:56 AM > To: linux-nvdimm@lists.01.org > Cc: Masayoshi Mizuma <msys.mizuma@gmail.com>; Qi, Fuli/斉 福利 > <qi.fuli@jp.fujitsu.com>; Mizuma, Masayoshi/水間 理仁 <m.mizuma@jp.fujitsu.com> > Subject: [PATCH] ndctl, monitor: Change the fail log priority to err. > > From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com> > > fail() is called if an error happens, but the log priority is debug, so user may > not notice the error. > Let's change the priority to err. > > Cc: QI Fuli <qi.fuli@jp.fujitsu.com> > Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com> > --- > ndctl/monitor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ndctl/monitor.c b/ndctl/monitor.c index 84d51c4..68bbf65 100644 > --- a/ndctl/monitor.c > +++ b/ndctl/monitor.c > @@ -40,7 +40,7 @@ static int did_fail; > #define fail(fmt, ...) \ > do { \ > did_fail = 1; \ > - dbg(ctx, "ndctl-%s:%s:%d: " fmt, \ > + err(ctx, "ndctl-%s:%s:%d: " fmt, \ > VERSION, __func__, __LINE__, ##__VA_ARGS__); \ } while (0) > Hi Masa, The debug messages which are from fail() include source code line numbers and function name, these are useful for developers not typical users. Therefore, we made it a debug level print. Currently the debug level cannot be outputted is a bug. I will make a patch for adding [--verbose] option to emit debug messages and changing the log level of some messages. Thanks, QI > -- > 2.18.0 > >
Hi QI, On 08/02/2018 07:42 AM, Qi, Fuli wrote: >> -----Original Message----- >> From: Masayoshi Mizuma [mailto:msys.mizuma@gmail.com] >> Sent: Thursday, August 2, 2018 3:56 AM >> To: linux-nvdimm@lists.01.org >> Cc: Masayoshi Mizuma <msys.mizuma@gmail.com>; Qi, Fuli/斉 福利 >> <qi.fuli@jp.fujitsu.com>; Mizuma, Masayoshi/水間 理仁 <m.mizuma@jp.fujitsu.com> >> Subject: [PATCH] ndctl, monitor: Change the fail log priority to err. >> >> From: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com> >> >> fail() is called if an error happens, but the log priority is debug, so user may >> not notice the error. >> Let's change the priority to err. >> >> Cc: QI Fuli <qi.fuli@jp.fujitsu.com> >> Signed-off-by: Masayoshi Mizuma <m.mizuma@jp.fujitsu.com> >> --- >> ndctl/monitor.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ndctl/monitor.c b/ndctl/monitor.c index 84d51c4..68bbf65 100644 >> --- a/ndctl/monitor.c >> +++ b/ndctl/monitor.c >> @@ -40,7 +40,7 @@ static int did_fail; >> #define fail(fmt, ...) \ >> do { \ >> did_fail = 1; \ >> - dbg(ctx, "ndctl-%s:%s:%d: " fmt, \ >> + err(ctx, "ndctl-%s:%s:%d: " fmt, \ >> VERSION, __func__, __LINE__, ##__VA_ARGS__); \ } while (0) >> > > Hi Masa, > > The debug messages which are from fail() include source code line numbers and function name, > these are useful for developers not typical users. Therefore, we made it a debug level print. > Currently the debug level cannot be outputted is a bug. > I will make a patch for adding [--verbose] option to emit debug messages and changing the log level of some messages. OK, make sense to me. Thanks, Masa > > Thanks, > QI > >> -- >> 2.18.0 >> >> > >
diff --git a/ndctl/monitor.c b/ndctl/monitor.c index 84d51c4..68bbf65 100644 --- a/ndctl/monitor.c +++ b/ndctl/monitor.c @@ -40,7 +40,7 @@ static int did_fail; #define fail(fmt, ...) \ do { \ did_fail = 1; \ - dbg(ctx, "ndctl-%s:%s:%d: " fmt, \ + err(ctx, "ndctl-%s:%s:%d: " fmt, \ VERSION, __func__, __LINE__, ##__VA_ARGS__); \ } while (0)