diff mbox series

[ndctl,v2,3/5] util/json: fix an error check for region resource

Message ID 20181003181506.17682-3-vishal.l.verma@intel.com (mailing list archive)
State New, archived
Headers show
Series [ndctl,v2,1/5] ndctl, lib: refactor badblocks retrieval routines | expand

Commit Message

Verma, Vishal L Oct. 3, 2018, 6:15 p.m. UTC 
The return type of ndctl_region_get_resource() is 'unsigned long long',
and therefore the error checking for it should be done against
ULLONG_MAX. Fix an instance where we were checking against ULONG_MAX.

Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
---
 util/json.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/util/json.c b/util/json.c
index 2d15859..30b56c3 100644
--- a/util/json.c
+++ b/util/json.c
@@ -470,7 +470,7 @@  struct json_object *util_region_badblocks_to_json(struct ndctl_region *region,
 
 		/* get start address of region */
 		addr = ndctl_region_get_resource(region);
-		if (addr == ULONG_MAX)
+		if (addr == ULLONG_MAX)
 			goto err_array;
 
 		/* get address of bad block */