diff mbox series

[ndctl,v2,1/3] autoconf: print more possible package names for <keyutils.h>

Message ID 20190215025725.19366-1-elliott@hpe.com (mailing list archive)
State New, archived
Headers show
Series [ndctl,v2,1/3] autoconf: print more possible package names for <keyutils.h> | expand

Commit Message

Elliott, Robert (Servers) Feb. 15, 2019, 2:57 a.m. UTC
The distro package names providing <keyutils.h> are inconsistent, so
print more than just one suggestion:
    keyutils-libs-devel (Red Hat)
    keyutils-devel (SUSE)
    libkeyutils-dev (Ubuntu)

Fixes: 86b078b44275 ("ndctl: add passphrase management commands")
Reviewed-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Robert Elliott <elliott@hpe.com>
---
 configure.ac | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Ira Weiny Feb. 15, 2019, 5:55 p.m. UTC | #1
On Thu, Feb 14, 2019 at 08:57:23PM -0600, Robert Elliott wrote:
> The distro package names providing <keyutils.h> are inconsistent, so
> print more than just one suggestion:
>     keyutils-libs-devel (Red Hat)
>     keyutils-devel (SUSE)
>     libkeyutils-dev (Ubuntu)
> 
> Fixes: 86b078b44275 ("ndctl: add passphrase management commands")
> Reviewed-by: Dan Williams <dan.j.williams@intel.com>
> Signed-off-by: Robert Elliott <elliott@hpe.com>

V2
Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  configure.ac | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index d27a2b1..8e57a53 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -170,8 +170,7 @@ AC_ARG_WITH([keyutils],
>  
>  if test "x$with_keyutils" = "xyes"; then
>  	AC_CHECK_HEADERS([keyutils.h],,[
> -		AC_MSG_ERROR([keyutils.h not found, consider installing
> -			      keyutils-libs-devel.])
> +		AC_MSG_ERROR([keyutils.h not found, consider installing the keyutils library development package (variously named keyutils-libs-devel, keyutils-devel, or libkeyutils-dev).])
>  		])
>  fi
>  AS_IF([test "x$with_keyutils" = "xyes"],
> -- 
> 2.20.1
> 
> _______________________________________________
> Linux-nvdimm mailing list
> Linux-nvdimm@lists.01.org
> https://lists.01.org/mailman/listinfo/linux-nvdimm
diff mbox series

Patch

diff --git a/configure.ac b/configure.ac
index d27a2b1..8e57a53 100644
--- a/configure.ac
+++ b/configure.ac
@@ -170,8 +170,7 @@  AC_ARG_WITH([keyutils],
 
 if test "x$with_keyutils" = "xyes"; then
 	AC_CHECK_HEADERS([keyutils.h],,[
-		AC_MSG_ERROR([keyutils.h not found, consider installing
-			      keyutils-libs-devel.])
+		AC_MSG_ERROR([keyutils.h not found, consider installing the keyutils library development package (variously named keyutils-libs-devel, keyutils-devel, or libkeyutils-dev).])
 		])
 fi
 AS_IF([test "x$with_keyutils" = "xyes"],