[v13,2/6] seq_buf: Export seq_buf_printf

Commit Message

Vaibhav Jain June 15, 2020, 12:44 p.m. UTC

'seq_buf' provides a very useful abstraction for writing to a string
buffer without needing to worry about it over-flowing. However even
though the API has been stable for couple of years now its still not
exported to kernel loadable modules limiting its usage.

Hence this patch proposes update to 'seq_buf.c' to mark
seq_buf_printf() which is part of the seq_buf API to be exported to
kernel loadable GPL modules. This symbol will be used in later parts
of this patch-set to simplify content creation for a sysfs attribute.

Cc: Piotr Maziarz <[e-mail]>
Cc: Cezary Rojewski <[e-mail]>
Cc: Christoph Hellwig <[e-mail]>
Cc: Steven Rostedt <[e-mail]>
Cc: Borislav Petkov <[e-mail]>
Acked-by: Steven Rostedt (VMware) <[e-mail]>
Signed-off-by: Vaibhav Jain <[e-mail]>
---
Changelog:

v12..v13:
* None

v11..v12:
* None

v10..v11:
* None

v9..v10:
* None

Resend:
* Added ack from Steven Rostedt

v8..v9:
* None

v7..v8:
* Updated the patch title [ Christoph Hellwig ]
* Updated patch description to replace confusing term 'external kernel
  modules' to 'kernel lodable modules'.

Resend:
* Added ack from Steven Rostedt

v6..v7:
* New patch in the series
---
 lib/seq_buf.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Borislav Petkov June 15, 2020, 12:55 p.m. UTC | #1

On Mon, Jun 15, 2020 at 06:14:03PM +0530, Vaibhav Jain wrote:
> 'seq_buf' provides a very useful abstraction for writing to a string
> buffer without needing to worry about it over-flowing. However even
> though the API has been stable for couple of years now its still not
> exported to kernel loadable modules limiting its usage.
> 
> Hence this patch proposes update to 'seq_buf.c' to mark
> seq_buf_printf() which is part of the seq_buf API to be exported to
> kernel loadable GPL modules. This symbol will be used in later parts
> of this patch-set to simplify content creation for a sysfs attribute.
> 
> Cc: Piotr Maziarz <[e-mail]>
> Cc: Cezary Rojewski <[e-mail]>
> Cc: Christoph Hellwig <[e-mail]>
> Cc: Steven Rostedt <[e-mail]>
> Cc: Borislav Petkov <[e-mail]>
> Acked-by: Steven Rostedt (VMware) <[e-mail]>
> Signed-off-by: Vaibhav Jain <[e-mail]>
> ---
> Changelog:
> 
> v12..v13:
> * None
> 
> v11..v12:
> * None

Can you please resend your patchset once a week like everyone else and
not flood inboxes with it?

Dan Williams June 15, 2020, 7:40 p.m. UTC | #2

On Mon, Jun 15, 2020 at 5:56 AM Borislav Petkov <[e-mail]> wrote:
>
> On Mon, Jun 15, 2020 at 06:14:03PM +0530, Vaibhav Jain wrote:
> > 'seq_buf' provides a very useful abstraction for writing to a string
> > buffer without needing to worry about it over-flowing. However even
> > though the API has been stable for couple of years now its still not
> > exported to kernel loadable modules limiting its usage.
> >
> > Hence this patch proposes update to 'seq_buf.c' to mark
> > seq_buf_printf() which is part of the seq_buf API to be exported to
> > kernel loadable GPL modules. This symbol will be used in later parts
> > of this patch-set to simplify content creation for a sysfs attribute.
> >
> > Cc: Piotr Maziarz <[e-mail]>
> > Cc: Cezary Rojewski <[e-mail]>
> > Cc: Christoph Hellwig <[e-mail]>
> > Cc: Steven Rostedt <[e-mail]>
> > Cc: Borislav Petkov <[e-mail]>
> > Acked-by: Steven Rostedt (VMware) <[e-mail]>
> > Signed-off-by: Vaibhav Jain <[e-mail]>
> > ---
> > Changelog:
> >
> > v12..v13:
> > * None
> >
> > v11..v12:
> > * None
>
> Can you please resend your patchset once a week like everyone else and
> not flood inboxes with it?

Hi Boris,

I gave Vaibhav some long shot hope that his series could be included
in my libnvdimm pull request for -rc1. Save for a last minute clang
report that I misread as a gcc warning, I likely would have included.
This spin is looking to address the last of the comments I had and
something I would consider for -rc2. So, in this case the resends were
requested by me and I'll take the grumbles on Vaibhav's behalf.

Steven Rostedt June 15, 2020, 9:24 p.m. UTC | #3

On Mon, 15 Jun 2020 14:55:52 +0200
Borislav Petkov <[e-mail]> wrote:

> Can you please resend your patchset once a week like everyone else and
> not flood inboxes with it?

Boris,

Haven't you automated your inbox yet? I have patchwork reading my INBOX
and it's smart enough to understand new series, and the old one simply
disappears as "superseded".

Email is just the wires to our infrastructure. Get with the times man! ;-)

-- Steve

Patch

diff --git a/lib/seq_buf.c b/lib/seq_buf.c
index 4e865d42ab03..707453f5d58e 100644
--- a/lib/seq_buf.c
+++ b/lib/seq_buf.c
@@ -91,6 +91,7 @@  int seq_buf_printf(struct seq_buf *s, const char *fmt, ...)
 
 	return ret;
 }
+EXPORT_SYMBOL_GPL(seq_buf_printf);
 
 #ifdef CONFIG_BINARY_PRINTF
 /**