diff mbox series

[v3,1/7] libnvdimm: fix memory leaks in of_pmem.c

Message ID 20200820021641.3188-2-thunder.leizhen@huawei.com (mailing list archive)
State New, archived
Headers show
Series bugfix and optimize for drivers/nvdimm | expand

Commit Message

Leizhen (ThunderTown) Aug. 20, 2020, 2:16 a.m. UTC
Currently, in the last error path of of_pmem_region_probe() and in
of_pmem_region_remove(), free the memory allocated by kstrdup() is
missing. Add kfree(priv->bus_desc.provider_name) to fix it.

Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Reviewed-by: Oliver O'Halloran <oohall@gmail.com>
 drivers/nvdimm/of_pmem.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series


diff --git a/drivers/nvdimm/of_pmem.c b/drivers/nvdimm/of_pmem.c
index 10dbdcdfb9ce913..1292ffca7b2ecc0 100644
--- a/drivers/nvdimm/of_pmem.c
+++ b/drivers/nvdimm/of_pmem.c
@@ -36,6 +36,7 @@  static int of_pmem_region_probe(struct platform_device *pdev)
 	priv->bus = bus = nvdimm_bus_register(&pdev->dev, &priv->bus_desc);
 	if (!bus) {
+		kfree(priv->bus_desc.provider_name);
 		return -ENODEV;
@@ -83,6 +84,7 @@  static int of_pmem_region_remove(struct platform_device *pdev)
 	struct of_pmem_private *priv = platform_get_drvdata(pdev);
+	kfree(priv->bus_desc.provider_name);
 	return 0;