From patchwork Thu Jul 1 20:09:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Verma, Vishal L" X-Patchwork-Id: 12354791 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5386D6D2D for ; Thu, 1 Jul 2021 20:10:28 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10032"; a="205606919" X-IronPort-AV: E=Sophos;i="5.83,315,1616482800"; d="scan'208";a="205606919" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2021 13:10:19 -0700 X-IronPort-AV: E=Sophos;i="5.83,315,1616482800"; d="scan'208";a="409271356" Received: from anandvig-mobl.amr.corp.intel.com (HELO vverma7-desk.amr.corp.intel.com) ([10.254.38.85]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2021 13:10:18 -0700 From: Vishal Verma To: , Cc: Dan Williams , Ben Widawsky , Alison Schofield , Ira Weiny , Vishal Verma Subject: [ndctl PATCH v3 10/21] libcxl: add support for the 'GET_LSA' command Date: Thu, 1 Jul 2021 14:09:54 -0600 Message-Id: <20210701201005.3065299-11-vishal.l.verma@intel.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210701201005.3065299-1-vishal.l.verma@intel.com> References: <20210701201005.3065299-1-vishal.l.verma@intel.com> Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Add a command allocator and accessor APIs for the 'GET_LSA' mailbox command. Cc: Ben Widawsky Cc: Dan Williams Signed-off-by: Vishal Verma --- cxl/lib/private.h | 5 +++++ cxl/lib/libcxl.c | 31 +++++++++++++++++++++++++++++++ cxl/libcxl.h | 3 +++ cxl/lib/libcxl.sym | 2 ++ 4 files changed, 41 insertions(+) diff --git a/cxl/lib/private.h b/cxl/lib/private.h index 2232f4c..fb1dd8e 100644 --- a/cxl/lib/private.h +++ b/cxl/lib/private.h @@ -73,6 +73,11 @@ struct cxl_cmd_identify { u8 qos_telemetry_caps; } __attribute__((packed)); +struct cxl_cmd_get_lsa_in { + le32 offset; + le32 length; +} __attribute__((packed)); + struct cxl_cmd_get_health_info { u8 health_status; u8 media_status; diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c index 2e33c5e..d2c38c9 100644 --- a/cxl/lib/libcxl.c +++ b/cxl/lib/libcxl.c @@ -799,6 +799,37 @@ CXL_EXPORT struct cxl_cmd *cxl_cmd_new_raw(struct cxl_memdev *memdev, return cmd; } +CXL_EXPORT struct cxl_cmd *cxl_cmd_new_get_lsa(struct cxl_memdev *memdev, + unsigned int offset, unsigned int length) +{ + struct cxl_cmd_get_lsa_in *get_lsa; + struct cxl_cmd *cmd; + + cmd = cxl_cmd_new_generic(memdev, CXL_MEM_COMMAND_ID_GET_LSA); + if (!cmd) + return NULL; + + get_lsa = (void *)cmd->send_cmd->in.payload; + get_lsa->offset = cpu_to_le32(offset); + get_lsa->length = cpu_to_le32(length); + return cmd; +} + +#define cmd_get_void(cmd, N) \ +do { \ + void *p = (void *)cmd->send_cmd->out.payload; \ + if (cmd->send_cmd->id != CXL_MEM_COMMAND_ID_##N) \ + return NULL; \ + if (cmd->status < 0) \ + return NULL; \ + return p; \ +} while(0); + +CXL_EXPORT void *cxl_cmd_get_lsa_get_payload(struct cxl_cmd *cmd) +{ + cmd_get_void(cmd, GET_LSA); +} + CXL_EXPORT int cxl_cmd_submit(struct cxl_cmd *cmd) { struct cxl_memdev *memdev = cmd->memdev; diff --git a/cxl/libcxl.h b/cxl/libcxl.h index 56ae4af..6edbd8d 100644 --- a/cxl/libcxl.h +++ b/cxl/libcxl.h @@ -71,6 +71,9 @@ int cxl_cmd_get_health_info_get_temperature(struct cxl_cmd *cmd); int cxl_cmd_get_health_info_get_dirty_shutdowns(struct cxl_cmd *cmd); int cxl_cmd_get_health_info_get_volatile_errors(struct cxl_cmd *cmd); int cxl_cmd_get_health_info_get_pmem_errors(struct cxl_cmd *cmd); +struct cxl_cmd *cxl_cmd_new_get_lsa(struct cxl_memdev *memdev, + unsigned int offset, unsigned int length); +void *cxl_cmd_get_lsa_get_payload(struct cxl_cmd *cmd); #ifdef __cplusplus } /* extern "C" */ diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym index e00443d..2c6193b 100644 --- a/cxl/lib/libcxl.sym +++ b/cxl/lib/libcxl.sym @@ -52,4 +52,6 @@ global: cxl_cmd_get_health_info_get_dirty_shutdowns; cxl_cmd_get_health_info_get_volatile_errors; cxl_cmd_get_health_info_get_pmem_errors; + cxl_cmd_new_get_lsa; + cxl_cmd_get_lsa_get_payload; } LIBCXL_2;