| Message ID | 20211109083309.584081-13-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [01/29] nvdimm/pmem: move dax_attribute_group from dax to pmem | expand |
On Tue, Nov 9, 2021 at 12:34 AM Christoph Hellwig <hch@lst.de> wrote: > > Despite its name copy_user_page expected kernel addresses, which is what > we already have. Yup, Reviewed-by: Dan Williams <dan.j.williams@intel.com>
On Tue, Nov 09, 2021 at 09:32:52AM +0100, Christoph Hellwig wrote: > Despite its name copy_user_page expected kernel addresses, which is what > we already have. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks ok, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/dax.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 4e3e5a283a916..73bd1439d8089 100644 > --- a/fs/dax.c > +++ b/fs/dax.c > @@ -728,7 +728,7 @@ static int copy_cow_page_dax(struct block_device *bdev, struct dax_device *dax_d > return rc; > } > vto = kmap_atomic(to); > - copy_user_page(vto, (void __force *)kaddr, vaddr, to); > + copy_user_page(vto, kaddr, vaddr, to); > kunmap_atomic(vto); > dax_read_unlock(id); > return 0; > -- > 2.30.2 >
diff --git a/fs/dax.c b/fs/dax.c index 4e3e5a283a916..73bd1439d8089 100644 --- a/fs/dax.c +++ b/fs/dax.c @@ -728,7 +728,7 @@ static int copy_cow_page_dax(struct block_device *bdev, struct dax_device *dax_d return rc; } vto = kmap_atomic(to); - copy_user_page(vto, (void __force *)kaddr, vaddr, to); + copy_user_page(vto, kaddr, vaddr, to); kunmap_atomic(vto); dax_read_unlock(id); return 0;
Despite its name copy_user_page expected kernel addresses, which is what we already have. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/dax.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)