| Message ID | 20220303111905.321089-2-hch@lst.de (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 143a70b8b4300faa92ad82468f65dccd440e7957 |
| Headers | show |
| Series | [01/10] iss-simdisk: use bvec_kmap_local in simdisk_submit_bio | expand |
On Thu, Mar 3, 2022 at 3:19 AM Christoph Hellwig <hch@lst.de> wrote: > > Using local kmaps slightly reduces the chances to stray writes, and > the bvec interface cleans up the code a little bit. > > Signed-off-by: Christoph Hellwig <hch@lst.de> > Reviewed-by: Ira Weiny <ira.weiny@intel.com> > --- > arch/xtensa/platforms/iss/simdisk.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Max Filippov <jcmvbkbc@gmail.com>
On Thu, 3 Mar 2022 14:18:56 +0300, Christoph Hellwig wrote: > Using local kmaps slightly reduces the chances to stray writes, and > the bvec interface cleans up the code a little bit. > > Applied, thanks! [01/10] iss-simdisk: use bvec_kmap_local in simdisk_submit_bio commit: 143a70b8b4300faa92ad82468f65dccd440e7957 [02/10] aoe: use bvec_kmap_local in bvcpy commit: b7ab4611b6c793100197abc93e069d6f9aab7960 [03/10] zram: use memcpy_to_bvec in zram_bvec_read commit: b3bd0a8a74ab970cc1cf0849e66bd0906741105b [04/10] zram: use memcpy_from_bvec in zram_bvec_write commit: bd3d3203eb84d08a6daef805efe9316b79d3bf3c [05/10] nvdimm-blk: use bvec_kmap_local in nd_blk_rw_integrity commit: 20072ec828640b7d23a0cfdbccf0dea48e77ba3e [06/10] nvdimm-btt: use bvec_kmap_local in btt_rw_integrity commit: 3205190655ea56ea5e00815eeff4dab2bde0af80 [07/10] bcache: use bvec_kmap_local in bio_csum commit: 07fee7aba5472d0e65345146a68b4bd1a8b656c3 [08/10] drbd: use bvec_kmap_local in drbd_csum_bio commit: 472278508dce25316e806e45778658c3e4b353b3 [09/10] drbd: use bvec_kmap_local in recv_dless_read commit: 3eddaa60b8411c135d1c71090dea9b59ff3f2e26 [10/10] floppy: use memcpy_{to,from}_bvec commit: 13d4ef0f66b7ee9415e101e213acaf94a0cb28ee Best regards,
diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c index 8eb6ad1a3a1de..0f0e0724397f4 100644 --- a/arch/xtensa/platforms/iss/simdisk.c +++ b/arch/xtensa/platforms/iss/simdisk.c @@ -108,13 +108,13 @@ static void simdisk_submit_bio(struct bio *bio) sector_t sector = bio->bi_iter.bi_sector; bio_for_each_segment(bvec, bio, iter) { - char *buffer = kmap_atomic(bvec.bv_page) + bvec.bv_offset; + char *buffer = bvec_kmap_local(&bvec); unsigned len = bvec.bv_len >> SECTOR_SHIFT; simdisk_transfer(dev, sector, len, buffer, bio_data_dir(bio) == WRITE); sector += len; - kunmap_atomic(buffer); + kunmap_local(buffer); } bio_endio(bio);