| Message ID | 20221203061848.113561-1-yuancan@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ndtest: Add checks for devm_kcalloc | expand |
diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c index 01ceb98c15a0..94fbb9d0fb6a 100644 --- a/tools/testing/nvdimm/test/ndtest.c +++ b/tools/testing/nvdimm/test/ndtest.c @@ -849,6 +849,8 @@ static int ndtest_probe(struct platform_device *pdev) sizeof(dma_addr_t), GFP_KERNEL); p->dimm_dma = devm_kcalloc(&p->pdev.dev, NUM_DCR, sizeof(dma_addr_t), GFP_KERNEL); + if (!p->dcr_dma || !p->label_dma || !p->dimm_dma) + return -ENOMEM; rc = ndtest_nvdimm_init(p); if (rc)
As the devm_kcalloc may return NULL, the return value needs to be checked to avoid NULL pointer dereference. Fixes: 9399ab61ad82 ("ndtest: Add dimms to the two buses") Signed-off-by: Yuan Can <yuancan@huawei.com> --- Changes in v2: - Fix typo in commit message tools/testing/nvdimm/test/ndtest.c | 2 ++ 1 file changed, 2 insertions(+)