| Message ID | 20240212123716.795996-1-pbrobinson@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e4b0925fcc89c4267b55c25acc254c041f5ccb21 |
| Headers | show |
| Series | libnvdimm: Fix ACPI_NFIT in BLK_DEV_PMEM help | expand |
On 2/12/24 5:37 AM, Peter Robinson wrote: > The ACPI_NFIT config option is described incorrectly as the > inverse NFIT_ACPI, which doesn't exist, so update the help > to the actual config option. > > Fixes: 18da2c9ee41a0 ("libnvdimm, pmem: move pmem to drivers/nvdimm/") Given this is only text correction and not a code bug, there's no need to backport the change with a Fixes tag. Otherwise looks good. > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- > drivers/nvdimm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/Kconfig b/drivers/nvdimm/Kconfig > index 77b06d54cc62e..fde3e17c836c8 100644 > --- a/drivers/nvdimm/Kconfig > +++ b/drivers/nvdimm/Kconfig > @@ -24,7 +24,7 @@ config BLK_DEV_PMEM > select ND_PFN if NVDIMM_PFN > help > Memory ranges for PMEM are described by either an NFIT > - (NVDIMM Firmware Interface Table, see CONFIG_NFIT_ACPI), a > + (NVDIMM Firmware Interface Table, see CONFIG_ACPI_NFIT), a > non-standard OEM-specific E820 memory type (type-12, see > CONFIG_X86_PMEM_LEGACY), or it is manually specified by the > 'memmap=nn[KMG]!ss[KMG]' kernel command line (see
Peter Robinson wrote: > The ACPI_NFIT config option is described incorrectly as the > inverse NFIT_ACPI, which doesn't exist, so update the help > to the actual config option. > > Fixes: 18da2c9ee41a0 ("libnvdimm, pmem: move pmem to drivers/nvdimm/") I don't think this warrants a fixes tag as this commit has been around since 2015 and has not bothered anyone. But the change is valid for the next merge window. > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > --- > drivers/nvdimm/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/nvdimm/Kconfig b/drivers/nvdimm/Kconfig > index 77b06d54cc62e..fde3e17c836c8 100644 > --- a/drivers/nvdimm/Kconfig > +++ b/drivers/nvdimm/Kconfig > @@ -24,7 +24,7 @@ config BLK_DEV_PMEM > select ND_PFN if NVDIMM_PFN > help > Memory ranges for PMEM are described by either an NFIT > - (NVDIMM Firmware Interface Table, see CONFIG_NFIT_ACPI), a > + (NVDIMM Firmware Interface Table, see CONFIG_ACPI_NFIT), a > non-standard OEM-specific E820 memory type (type-12, see > CONFIG_X86_PMEM_LEGACY), or it is manually specified by the > 'memmap=nn[KMG]!ss[KMG]' kernel command line (see > -- > 2.43.0 >
On Mon, 12 Feb 2024 at 17:01, Ira Weiny <ira.weiny@intel.com> wrote: > > Peter Robinson wrote: > > The ACPI_NFIT config option is described incorrectly as the > > inverse NFIT_ACPI, which doesn't exist, so update the help > > to the actual config option. > > > > Fixes: 18da2c9ee41a0 ("libnvdimm, pmem: move pmem to drivers/nvdimm/") > > I don't think this warrants a fixes tag as this commit has been around > since 2015 and has not bothered anyone. But the change is valid for the > next merge window. Well I added it because it does fix a legitimate problem, even if it's only documentation, I don't mind if you strip it, it's always hard to tell what maintainers want, because some explicitly want it added and some don't. > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com> > > --- > > drivers/nvdimm/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/nvdimm/Kconfig b/drivers/nvdimm/Kconfig > > index 77b06d54cc62e..fde3e17c836c8 100644 > > --- a/drivers/nvdimm/Kconfig > > +++ b/drivers/nvdimm/Kconfig > > @@ -24,7 +24,7 @@ config BLK_DEV_PMEM > > select ND_PFN if NVDIMM_PFN > > help > > Memory ranges for PMEM are described by either an NFIT > > - (NVDIMM Firmware Interface Table, see CONFIG_NFIT_ACPI), a > > + (NVDIMM Firmware Interface Table, see CONFIG_ACPI_NFIT), a > > non-standard OEM-specific E820 memory type (type-12, see > > CONFIG_X86_PMEM_LEGACY), or it is manually specified by the > > 'memmap=nn[KMG]!ss[KMG]' kernel command line (see > > -- > > 2.43.0 > > > >
diff --git a/drivers/nvdimm/Kconfig b/drivers/nvdimm/Kconfig index 77b06d54cc62e..fde3e17c836c8 100644 --- a/drivers/nvdimm/Kconfig +++ b/drivers/nvdimm/Kconfig @@ -24,7 +24,7 @@ config BLK_DEV_PMEM select ND_PFN if NVDIMM_PFN help Memory ranges for PMEM are described by either an NFIT - (NVDIMM Firmware Interface Table, see CONFIG_NFIT_ACPI), a + (NVDIMM Firmware Interface Table, see CONFIG_ACPI_NFIT), a non-standard OEM-specific E820 memory type (type-12, see CONFIG_X86_PMEM_LEGACY), or it is manually specified by the 'memmap=nn[KMG]!ss[KMG]' kernel command line (see
The ACPI_NFIT config option is described incorrectly as the inverse NFIT_ACPI, which doesn't exist, so update the help to the actual config option. Fixes: 18da2c9ee41a0 ("libnvdimm, pmem: move pmem to drivers/nvdimm/") Signed-off-by: Peter Robinson <pbrobinson@gmail.com> --- drivers/nvdimm/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)