| Message ID | 20240219-device_cleanup-dax-v1-1-6b319ee89dc2@marliere.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2c720b492c59b070930aa1be8bef6e256d3bf4b2 |
| Delegated to: | Ira Weiny |
| Headers | show |
| Series | dax: constify the struct device_type usage | expand |
On 2/19/24 5:47 AM, Ricardo B. Marliere wrote: > Since commit aed65af1cc2f ("drivers: make device_type const"), the driver > core can properly handle constant struct device_type. Move the > dax_mapping_type variable to be a constant structure as well, placing it > into read-only memory which can not be modified at runtime. > > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> Reviewed-by: Dave Jiang <dave.jiang@intel.com> > --- > drivers/dax/bus.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c > index 1ff1ab5fa105..e265ba019785 100644 > --- a/drivers/dax/bus.c > +++ b/drivers/dax/bus.c > @@ -763,7 +763,7 @@ static const struct attribute_group *dax_mapping_attribute_groups[] = { > NULL, > }; > > -static struct device_type dax_mapping_type = { > +static const struct device_type dax_mapping_type = { > .release = dax_mapping_release, > .groups = dax_mapping_attribute_groups, > }; > > --- > base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d > change-id: 20240219-device_cleanup-dax-d82fd0c67ffd > > Best regards,
diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index 1ff1ab5fa105..e265ba019785 100644 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -763,7 +763,7 @@ static const struct attribute_group *dax_mapping_attribute_groups[] = { NULL, }; -static struct device_type dax_mapping_type = { +static const struct device_type dax_mapping_type = { .release = dax_mapping_release, .groups = dax_mapping_attribute_groups, };
Since commit aed65af1cc2f ("drivers: make device_type const"), the driver core can properly handle constant struct device_type. Move the dax_mapping_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net> --- drivers/dax/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: b401b621758e46812da61fa58a67c3fd8d91de0d change-id: 20240219-device_cleanup-dax-d82fd0c67ffd Best regards,