| Message ID | 20250215021319.1948097-1-alison.schofield@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [ndctl] cxl/lib: remove unimplemented symbol cxl_mapping_get_region | expand |
On Fri, Feb 14, 2025 at 06:13:16PM -0800, alison.schofield@intel.com wrote: > From: Alison Schofield <alison.schofield@intel.com> > > User reports this symbol was added but has never had an implementation > causing their linker ld.lld to fail like so: > > ld.lld: error: version script assignment of 'LIBCXL_3' to symbol 'cxl_mapping_get_region' failed: symbol not defined > > This likely worked for some builds but not others because of different > toolchains (linkers), compiler optimizations (garbage collection), or > linker flags (ignoring or only warning on unused symbols). > > Clean this up by removing the symbol. > > Reposted here from github pull request: > https://github.com/pmem/ndctl/pull/267/ > > Signed-off-by: Alison Schofield <alison.schofield@intel.com> Reviewed-by: Fan Ni <fan.ni@samsung.com> > --- > cxl/lib/libcxl.sym | 1 - > cxl/libcxl.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym > index 0c155a40ad47..763151fbef59 100644 > --- a/cxl/lib/libcxl.sym > +++ b/cxl/lib/libcxl.sym > @@ -208,7 +208,6 @@ global: > cxl_mapping_get_first; > cxl_mapping_get_next; > cxl_mapping_get_decoder; > - cxl_mapping_get_region; > cxl_mapping_get_position; > cxl_decoder_get_by_name; > cxl_decoder_get_memdev; > diff --git a/cxl/libcxl.h b/cxl/libcxl.h > index 0a5fd0e13cc2..43c082acd836 100644 > --- a/cxl/libcxl.h > +++ b/cxl/libcxl.h > @@ -354,7 +354,6 @@ struct cxl_memdev_mapping *cxl_mapping_get_first(struct cxl_region *region); > struct cxl_memdev_mapping * > cxl_mapping_get_next(struct cxl_memdev_mapping *mapping); > struct cxl_decoder *cxl_mapping_get_decoder(struct cxl_memdev_mapping *mapping); > -struct cxl_region *cxl_mapping_get_region(struct cxl_memdev_mapping *mapping); > unsigned int cxl_mapping_get_position(struct cxl_memdev_mapping *mapping); > > #define cxl_mapping_foreach(region, mapping) \ > -- > 2.37.3 >
diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym index 0c155a40ad47..763151fbef59 100644 --- a/cxl/lib/libcxl.sym +++ b/cxl/lib/libcxl.sym @@ -208,7 +208,6 @@ global: cxl_mapping_get_first; cxl_mapping_get_next; cxl_mapping_get_decoder; - cxl_mapping_get_region; cxl_mapping_get_position; cxl_decoder_get_by_name; cxl_decoder_get_memdev; diff --git a/cxl/libcxl.h b/cxl/libcxl.h index 0a5fd0e13cc2..43c082acd836 100644 --- a/cxl/libcxl.h +++ b/cxl/libcxl.h @@ -354,7 +354,6 @@ struct cxl_memdev_mapping *cxl_mapping_get_first(struct cxl_region *region); struct cxl_memdev_mapping * cxl_mapping_get_next(struct cxl_memdev_mapping *mapping); struct cxl_decoder *cxl_mapping_get_decoder(struct cxl_memdev_mapping *mapping); -struct cxl_region *cxl_mapping_get_region(struct cxl_memdev_mapping *mapping); unsigned int cxl_mapping_get_position(struct cxl_memdev_mapping *mapping); #define cxl_mapping_foreach(region, mapping) \