From patchwork Sun Feb 21 17:09:25 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Boaz Harrosh X-Patchwork-Id: 8368481 Return-Path: X-Original-To: patchwork-linux-nvdimm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 99B999F2F0 for ; Sun, 21 Feb 2016 17:09:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B4A7C2041C for ; Sun, 21 Feb 2016 17:09:30 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DF7612040F for ; Sun, 21 Feb 2016 17:09:29 +0000 (UTC) Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 27CE21A1EEF; Sun, 21 Feb 2016 09:09:31 -0800 (PST) X-Original-To: linux-nvdimm@ml01.01.org Delivered-To: linux-nvdimm@ml01.01.org Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 381501A1EEF for ; Sun, 21 Feb 2016 09:09:30 -0800 (PST) Received: by mail-wm0-x235.google.com with SMTP id a4so133080635wme.1 for ; Sun, 21 Feb 2016 09:09:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=plexistor-com.20150623.gappssmtp.com; s=20150623; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-transfer-encoding; bh=0n0CbgocC0xyAokhIToMCxMzLKgiIWPiwDzZ/Dzcm4g=; b=mr8/UgK2RNxxZ9Mns6YjHj3nrHQ76pQk/KdcuEQr+4lzCoIg+6IiE/MF/cmvVVuySk TZoTzWjHhqT5+dU2rSQagBryuKfgZHCWOkbs7Ey0r1zcg3oiyg/zyHF1Glw2UBZA2UDQ igxoKpgSegOqc8j5zTDEVTmqc+UIrvBIu/y7VV449cNgc9qTD9orTIqsTc0rWqDkYpZg j9GjyDCd1emirnxYER4IKWi1Li48roTWupYi6cg+2BXXp/JRXTlCHXoFpRSugkwdnUYu EbY5Q7HTwivZBDjKznzg0n/Ru9Ft9VtB0B7/XGJ+B13NYPpwyG19Tp0sZb603JGHAXHe kOow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-transfer-encoding; bh=0n0CbgocC0xyAokhIToMCxMzLKgiIWPiwDzZ/Dzcm4g=; b=cqtn0FXO2sNgu7gKw73LG46Ka9SCaFEhCudlQcEpTdQ0gaUaMEVLupDoN5vxyW/Rlc gPGp1CxESSsNbnvAf1AZRnfk5Ki9gS8LmyfZ96MFrZK6/rnDjIqUMLOJsx5TFhsxzUC5 Frh1nBCrDcLUa5n2tS4kzJA2srEK87aHiyPv+2XZ/o7EdCWGint+/YFOFz0H+bOeaQFm eX3dD1auhAR6LtfcSx1KPtMyho8vBObvqfuYYfheAKOBUlLYdImc1kKKO93+4pSQpohh mhnCv5GMFx4Hs5cG/75rTiU5eueBxSbWrvGKZihEANRglkfjYr4F9cdvkuryuixjIy0R 48nA== X-Gm-Message-State: AG10YOTy5omWSvi2RnOCk7UFsYk3WIjTgVS+3u5A/7i+KTO93S06DLpKHPv+vtpu8ur6Zg== X-Received: by 10.28.107.140 with SMTP id a12mr8487187wmi.77.1456074567470; Sun, 21 Feb 2016 09:09:27 -0800 (PST) Received: from [10.0.0.5] ([207.232.55.62]) by smtp.googlemail.com with ESMTPSA id ka4sm20757620wjc.47.2016.02.21.09.09.26 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 21 Feb 2016 09:09:26 -0800 (PST) Message-ID: <56C9EF45.4040205@plexistor.com> Date: Sun, 21 Feb 2016 19:09:25 +0200 From: Boaz Harrosh User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Dan Williams , Ross Zwisler , linux-nvdimm , Matthew Wilcox , Dave Chinner Subject: [RFC 1/1] util: add pmem-aware flag to mmap() References: <56C9EDCF.8010007@plexistor.com> In-Reply-To: <56C9EDCF.8010007@plexistor.com> Cc: Arnd Bergmann X-BeenThere: linux-nvdimm@lists.01.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "Linux-nvdimm developer list." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Yigal Korman Tell the kernel that the library is responsible for the persistence of its writes and there's no need to flush/drain the pmem. TODO: use #ifdef to check if the pmem-aware flag exists Signed-off-by: Yigal Korman --- src/common/util.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/src/common/util.c b/src/common/util.c index 17b3305..0f6feaa 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -312,9 +312,14 @@ util_map(int fd, size_t len, int cow, size_t req_align) void *base; void *addr = util_map_hint(len, req_align); + int flags = MAP_PMEM_AWARE; - if ((base = mmap(addr, len, PROT_READ|PROT_WRITE, - (cow) ? MAP_PRIVATE|MAP_NORESERVE : MAP_SHARED, + if (cow) + flags |= MAP_SHARED; + else + flags |= MAP_PRIVATE | MAP_NORESERVE; + + if ((base = mmap(addr, len, PROT_READ|PROT_WRITE, flags, fd, 0)) == MAP_FAILED) { ERR("!mmap %zu bytes", len); return NULL;