From patchwork Thu Mar 14 04:05:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alison Schofield X-Patchwork-Id: 13592070 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6912E5398 for ; Thu, 14 Mar 2024 04:05:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.10 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710389130; cv=none; b=u+aHgDI7wAZ60Q4Cyd6TAJWCiPTFYz0NRKOH0JTXI/lDHtjSQp+YTgBcxBtk6rRv7aSAeaJ56jSjWNBhmWazu5B67MjzmDzI9qQuqIFex5w/9dtqAThvSgXe3uMN8WHVtj+/bWiNilQnQjeI2zccRQlGNWCKvRYARIgZQbAxu4Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710389130; c=relaxed/simple; bh=w2PzexwB2loTJZ+xDVTgYJmA2I7IIdSALPdEyuLuCjI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=iMnhGRv8XxD2gD9CYaFUY6iciEs0lQQuJT6V9MpUe0a+CizfMZOdi1MjQ7U+CEbFgVGQgUwz0iH5uNKjpKODwiaXmeJAq/y2PT4qhk2aQbpnHexG4AhVN5Cx5S3aTfrNTjb1YmHtMI9swTBZzlxS4xJcr33hTA9d69N/7Q/3jR4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=RrDV0LiZ; arc=none smtp.client-ip=198.175.65.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="RrDV0LiZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1710389129; x=1741925129; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=w2PzexwB2loTJZ+xDVTgYJmA2I7IIdSALPdEyuLuCjI=; b=RrDV0LiZUfFpfYff8BtahEr1S7KboEvCUZMnT5sOto6BtBFpNVJ59VXG vVYAj0vCoj88CV7wz1wcGgVCfdeAt++J2RVgPXQfiiu3Qr+reA3bSIXWl yy75haB+WdPpTld/jE66YBCDohbDJjnAhINHmnL9Ye5YhaQfXDGu+sjfb nR+sWZ8dcXRzVfCs+SjjS90bZtiqBnTtuBhrkm0P2CuU0bihGqONjyJRC PrU6uVpo3FFU4K77brDLjDFuw21e29wexzHwXQxh0Tt+316UpYFjQ6XaT Lp3N0TalUWeg0chSdWTGqfiQ3DhmM1/mvGthPXoG0wkvF0aFVhIL94W3x A==; X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="22648793" X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="22648793" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 21:05:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="12080671" Received: from aschofie-mobl2.amr.corp.intel.com (HELO localhost) ([10.209.86.131]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 21:05:26 -0700 From: alison.schofield@intel.com To: Vishal Verma Cc: Alison Schofield , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, Dave Jiang Subject: [ndctl PATCH v11 1/7] libcxl: add interfaces for GET_POISON_LIST mailbox commands Date: Wed, 13 Mar 2024 21:05:17 -0700 Message-Id: X-Mailer: git-send-email 2.40.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: nvdimm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Alison Schofield CXL devices maintain a list of locations that are poisoned or result in poison if the addresses are accessed by the host. Per the spec (CXL 3.1 8.2.9.9.4.1), the device returns the Poison List as a set of Media Error Records that include the source of the error, the starting device physical address and length. Trigger the retrieval of the poison list by writing to the memory device sysfs attribute: trigger_poison_list. The CXL driver only offers triggering per memdev, so the trigger by region interface offered here is a convenience API that triggers a poison list retrieval for each memdev contributing to a region. int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev); int cxl_region_trigger_poison_list(struct cxl_region *region); The resulting poison records are logged as kernel trace events named 'cxl_poison'. Signed-off-by: Alison Schofield Reviewed-by: Dave Jiang --- cxl/lib/libcxl.c | 47 ++++++++++++++++++++++++++++++++++++++++++++++ cxl/lib/libcxl.sym | 2 ++ cxl/libcxl.h | 2 ++ 3 files changed, 51 insertions(+) diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c index ff27cdf7c44a..73db8f15c704 100644 --- a/cxl/lib/libcxl.c +++ b/cxl/lib/libcxl.c @@ -1761,6 +1761,53 @@ CXL_EXPORT int cxl_memdev_disable_invalidate(struct cxl_memdev *memdev) return 0; } +CXL_EXPORT int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev) +{ + struct cxl_ctx *ctx = cxl_memdev_get_ctx(memdev); + char *path = memdev->dev_buf; + int len = memdev->buf_len, rc; + + if (snprintf(path, len, "%s/trigger_poison_list", + memdev->dev_path) >= len) { + err(ctx, "%s: buffer too small\n", + cxl_memdev_get_devname(memdev)); + return -ENXIO; + } + rc = sysfs_write_attr(ctx, path, "1\n"); + if (rc < 0) { + fprintf(stderr, + "%s: Failed write sysfs attr trigger_poison_list\n", + cxl_memdev_get_devname(memdev)); + return rc; + } + return 0; +} + +CXL_EXPORT int cxl_region_trigger_poison_list(struct cxl_region *region) +{ + struct cxl_memdev_mapping *mapping; + int rc; + + cxl_mapping_foreach(region, mapping) { + struct cxl_decoder *decoder; + struct cxl_memdev *memdev; + + decoder = cxl_mapping_get_decoder(mapping); + if (!decoder) + continue; + + memdev = cxl_decoder_get_memdev(decoder); + if (!memdev) + continue; + + rc = cxl_memdev_trigger_poison_list(memdev); + if (rc) + return rc; + } + + return 0; +} + CXL_EXPORT int cxl_memdev_enable(struct cxl_memdev *memdev) { struct cxl_ctx *ctx = cxl_memdev_get_ctx(memdev); diff --git a/cxl/lib/libcxl.sym b/cxl/lib/libcxl.sym index de2cd84b2960..3f709c60db3d 100644 --- a/cxl/lib/libcxl.sym +++ b/cxl/lib/libcxl.sym @@ -280,4 +280,6 @@ global: cxl_memdev_get_pmem_qos_class; cxl_memdev_get_ram_qos_class; cxl_region_qos_class_mismatch; + cxl_memdev_trigger_poison_list; + cxl_region_trigger_poison_list; } LIBCXL_6; diff --git a/cxl/libcxl.h b/cxl/libcxl.h index a6af3fb04693..29165043ca3f 100644 --- a/cxl/libcxl.h +++ b/cxl/libcxl.h @@ -467,6 +467,8 @@ enum cxl_setpartition_mode { int cxl_cmd_partition_set_mode(struct cxl_cmd *cmd, enum cxl_setpartition_mode mode); +int cxl_memdev_trigger_poison_list(struct cxl_memdev *memdev); +int cxl_region_trigger_poison_list(struct cxl_region *region); int cxl_cmd_alert_config_set_life_used_prog_warn_threshold(struct cxl_cmd *cmd, int threshold);