[net-next,v2,00/20] net: ethernet: ti: clean up and optimizations

Message

Grygorii Strashko April 26, 2019, 5:12 p.m. UTC

Hi All,

This is a preparation series for introducing new switchbase TI CPSW driver which
was originally introduced [1][2] by Ilias Apalodimas <[e-mail]> 
and also discussed in private mails and at Netdev x13 confernce.

Following discussions and suggestions (mostly by Andrew and Ivan) we going
to introduce the new driver which is operating in dual-emac mode
by default, thus working as 2 individual network interfaces.
When both interfaces joined the bridge - CPSW driver will enter a switch
mode and discard dual_mac configuration. The CPSW will be switched back
to dual_mac mode if any port leaves the bridge. All configuration is going to be
implemented via switchdev API.

Hence overall change is already very big I'm sending prerequisite patches which
are mostly minor fixes/clean ups and code refactoring to separate common parts
to be reused by both drivers.
Probably the most serious change from functional point of view is Patch 11.

These patches were NFS boot tetested on TI AM335x/AM437x/AM5xx boards.

These patches can be found at:
 [e-mail]:~gragst/ti-linux-kernel/gragsts-ti-linux-kernel.git
 branch: lkml-5.1-cpsw-clean-up-v2

changes in v2:
- added new patch 16 to get rid of force type conversation
- other chages metioned in patches

Grygorii Strashko (20):
  net: ethernet: ti: convert to SPDX license identifiers
  net: ethernet: ti: cpsw: drop TI_DAVINCI_CPDMA config option
  net: ethernet: ti: cpsw: drop CONFIG_TI_CPSW_ALE config option
  net: ethernet: ti: cpsw: update cpsw_split_res() to accept cpsw_common
  net: ethernet: ti: cpsw: use local var dev in probe
  net: ethernet: ti: cpsw: drop pinctrl_pm_select_default_state call
  net: ethernet: ti: cpsw: use devm_alloc_etherdev_mqs()
  net: ethernet: ti: cpsw: drop cpsw_tx_packet_submit()
  net: ethernet: ti: ale: fix mcast super setting
  net: ethernet: ti: ale: use define for host port in
    cpsw_ale_set_allmulti()
  net: ethernet: ti: cpsw: fix allmulti cfg in dual_mac mode
  net: ethernet: ti: ale: do not auto delete mcast super entries
  net: ethernet: ti: davinci_mdio: use devm_ioremap()
  net: ethernet: ti: cpsw: refactor probe to group common hw
    initialization
  net: ethernet: ti: cpsw: move cpsw definitions in priv header
  net: ethernet: ti: davinci_cpdma: use dma_addr_t for desc_mem_phys and
    desc_hw_addr
  net: ethernet: ti: cpsw: move common hw init code in separate func
  net: ethernet: ti: cpsw: introduce mac sl module api
  net: ethernet: ti: cpsw: switch to use mac sl api
  net: ethernet: ti: cpsw: move ethtool func in separate file

 drivers/net/ethernet/ti/Kconfig          |   19 -
 drivers/net/ethernet/ti/Makefile         |    9 +-
 drivers/net/ethernet/ti/cpmac.c          |   14 +-
 drivers/net/ethernet/ti/cpsw-common.c    |   12 +-
 drivers/net/ethernet/ti/cpsw-phy-sel.c   |    9 +-
 drivers/net/ethernet/ti/cpsw.c           | 1530 +++-------------------
 drivers/net/ethernet/ti/cpsw.h           |    9 +-
 drivers/net/ethernet/ti/cpsw_ale.c       |   55 +-
 drivers/net/ethernet/ti/cpsw_ale.h       |   12 +-
 drivers/net/ethernet/ti/cpsw_ethtool.c   |  719 ++++++++++
 drivers/net/ethernet/ti/cpsw_priv.c      |  132 ++
 drivers/net/ethernet/ti/cpsw_priv.h      |  429 ++++++
 drivers/net/ethernet/ti/cpsw_sl.c        |  328 +++++
 drivers/net/ethernet/ti/cpsw_sl.h        |   73 ++
 drivers/net/ethernet/ti/cpts.c           |   14 +-
 drivers/net/ethernet/ti/cpts.h           |   14 +-
 drivers/net/ethernet/ti/davinci_cpdma.c  |   37 +-
 drivers/net/ethernet/ti/davinci_cpdma.h  |   13 +-
 drivers/net/ethernet/ti/davinci_emac.c   |   16 +-
 drivers/net/ethernet/ti/davinci_mdio.c   |   19 +-
 drivers/net/ethernet/ti/netcp.h          |   10 +-
 drivers/net/ethernet/ti/netcp_core.c     |   10 +-
 drivers/net/ethernet/ti/netcp_ethss.c    |   10 +-
 drivers/net/ethernet/ti/netcp_sgmii.c    |    9 +-
 drivers/net/ethernet/ti/netcp_xgbepcsr.c |    9 +-
 25 files changed, 1870 insertions(+), 1641 deletions(-)
 create mode 100644 drivers/net/ethernet/ti/cpsw_ethtool.c
 create mode 100644 drivers/net/ethernet/ti/cpsw_priv.c
 create mode 100644 drivers/net/ethernet/ti/cpsw_priv.h
 create mode 100644 drivers/net/ethernet/ti/cpsw_sl.c
 create mode 100644 drivers/net/ethernet/ti/cpsw_sl.h

Comments

Jakub Kicinski April 26, 2019, 9:20 p.m. UTC | #1

On Fri, 26 Apr 2019 20:12:22 +0300, Grygorii Strashko wrote:
> Hi All,
> 
> This is a preparation series for introducing new switchbase TI CPSW driver which
> was originally introduced [1][2] by Ilias Apalodimas <[e-mail]> 
> and also discussed in private mails and at Netdev x13 confernce.
> 
> Following discussions and suggestions (mostly by Andrew and Ivan) we going
> to introduce the new driver which is operating in dual-emac mode
> by default, thus working as 2 individual network interfaces.
> When both interfaces joined the bridge - CPSW driver will enter a switch
> mode and discard dual_mac configuration. The CPSW will be switched back
> to dual_mac mode if any port leaves the bridge. All configuration is going to be
> implemented via switchdev API.
> 
> Hence overall change is already very big I'm sending prerequisite patches which
> are mostly minor fixes/clean ups and code refactoring to separate common parts
> to be reused by both drivers.
> Probably the most serious change from functional point of view is Patch 11.
> 
> These patches were NFS boot tetested on TI AM335x/AM437x/AM5xx boards.

FWIW I don't see anything too objectionable here, we will see if the
merging of the shared module bites us or not :)

One note - please try to keep your submissions under 16 patches in a
single series (that's 15 at most).

David Miller April 27, 2019, 9:12 p.m. UTC | #2

From: Grygorii Strashko <[e-mail]>
Date: Fri, 26 Apr 2019 20:12:22 +0300

> This is a preparation series for introducing new switchbase TI CPSW driver which
> was originally introduced [1][2] by Ilias Apalodimas <[e-mail]> 
> and also discussed in private mails and at Netdev x13 confernce.
 ...

Series applied, thank you.