mbox series

[0/3] ARM: OMAP1: ams-delta: Clean up GPIO setup for MODEM

Message ID 20180820181333.2527-1-jmkrzyszt@gmail.com (mailing list archive)
Headers show
Series ARM: OMAP1: ams-delta: Clean up GPIO setup for MODEM | expand

Message

Janusz Krzysztofik Aug. 20, 2018, 6:13 p.m. UTC
Convert modem related GPIO setup from integer space to GPIO descriptors.
Also, restore original initialization order of the MODEM device and its
related GPIO pins.

Cleanup of MODEM relaated regulator setup is postponed while waiting for
upcoming conversion of fixed regulator API to GPIO descriptors.


Janusz Krzysztofik (3):
      ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
      ARM: OMAP1: ams-delta: initialize latch2 pins to safe values
      ARM: OMAP1: ams-delta: register MODEM device earlier


diffstat:
 board-ams-delta.c |  120 +++++++++++++++++++++++++++++++++++++++---------------
 board-ams-delta.h |    7 ---
 2 files changed, 88 insertions(+), 39 deletions(-)

Comments

Tony Lindgren Sept. 7, 2018, 4:56 p.m. UTC | #1
* Janusz Krzysztofik <jmkrzyszt@gmail.com> [180820 11:16]:
> 
> Convert modem related GPIO setup from integer space to GPIO descriptors.
> Also, restore original initialization order of the MODEM device and its
> related GPIO pins.
> 
> Cleanup of MODEM relaated regulator setup is postponed while waiting for
> upcoming conversion of fixed regulator API to GPIO descriptors.
> 
> 
> Janusz Krzysztofik (3):
>       ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
>       ARM: OMAP1: ams-delta: initialize latch2 pins to safe values
>       ARM: OMAP1: ams-delta: register MODEM device earlier

Janusz, can you please repost this series based on v4.19-rc1
with Linus' acks?

At least the header file has moved around now.

And as this also conflicts with your earlier patch
"ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor"
please repost that too in the same series.

If you have other arch/arm/*omap*/* related patches then
please repost those too, these are the only ones I still had
tagged :)

Regards,

Tony
Janusz Krzysztofik Sept. 9, 2018, 11:44 p.m. UTC | #2
Convert modem related GPIO setup from integer space to GPIO descriptors.
Also, restore original initialization order of the MODEM device and its
related GPIO pins.

Cleanup of MODEM relaated regulator setup is postponed while waiting for
upcoming conversion of fixed regulator API to GPIO descriptors.


Janusz Krzysztofik (3):
      ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
      ARM: OMAP1: ams-delta: initialize latch2 pins to safe values
      ARM: OMAP1: ams-delta: register MODEM device earlier


Changelog:
v2:
- rebased on v4.19-rc1
- added Reviewed-by: obtained from Linus Walleij

Please ignore the patch "ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO"
sent alone on 2018-07-17.

Thanks,
Janusz


diffstat:
 board-ams-delta.c |  121 +++++++++++++++++++++++++++++++++++++++---------------
 board-ams-delta.h |    7 ---
 2 files changed, 88 insertions(+), 40 deletions(-)
Janusz Krzysztofik Sept. 10, 2018, 9:49 p.m. UTC | #3
On Monday, September 10, 2018 1:44:16 AM CEST Janusz Krzysztofik wrote:
> 
> Convert modem related GPIO setup from integer space to GPIO descriptors.
> Also, restore original initialization order of the MODEM device and its
> related GPIO pins.
> 
> Cleanup of MODEM relaated regulator setup is postponed while waiting for
> upcoming conversion of fixed regulator API to GPIO descriptors.
> 
> 
> Janusz Krzysztofik (3):
>       ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
>       ARM: OMAP1: ams-delta: initialize latch2 pins to safe values
>       ARM: OMAP1: ams-delta: register MODEM device earlier
> 
> 
> Changelog:
> v2:
> - rebased on v4.19-rc1

Hi Tony,

I forgot to mention: please apply on top of "[PATCH v3 0/3] ARM: OMAP1: ams-
delta: Complete driver gpiod migration" series. Sorry.

Thanks,
Janusz

> - added Reviewed-by: obtained from Linus Walleij
> 
> Please ignore the patch "ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO"
> sent alone on 2018-07-17.
> 
> Thanks,
> Janusz
> 
> 
> diffstat:
>  board-ams-delta.c |  121 ++++++++++++++++++++++++++++++++++++++
+---------------
>  board-ams-delta.h |    7 ---
>  2 files changed, 88 insertions(+), 40 deletions(-)
> 
>
Tony Lindgren Sept. 20, 2018, 9:23 p.m. UTC | #4
* Janusz Krzysztofik <jmkrzyszt@gmail.com> [180910 21:52]:
> On Monday, September 10, 2018 1:44:16 AM CEST Janusz Krzysztofik wrote:
> > 
> > Convert modem related GPIO setup from integer space to GPIO descriptors.
> > Also, restore original initialization order of the MODEM device and its
> > related GPIO pins.
> > 
> > Cleanup of MODEM relaated regulator setup is postponed while waiting for
> > upcoming conversion of fixed regulator API to GPIO descriptors.
> > 
> > 
> > Janusz Krzysztofik (3):
> >       ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
> >       ARM: OMAP1: ams-delta: initialize latch2 pins to safe values
> >       ARM: OMAP1: ams-delta: register MODEM device earlier
> > 
> > 
> > Changelog:
> > v2:
> > - rebased on v4.19-rc1
> 
> Hi Tony,
> 
> I forgot to mention: please apply on top of "[PATCH v3 0/3] ARM: OMAP1: ams-
> delta: Complete driver gpiod migration" series. Sorry.

Hmm but then in that thread you said that it won't apply.. So I'm applying
this series into omap-for-v4.20/omap1 branch. I just modified the second
patch in this series for the unchanged header location.

I suggest you send the mtd patch separately to mtd maintainers, the fb patch
separately to fb maintainers and then let's do the header move after all
those are merged as a clean-up. That avoids some dependencies between these
branches.

Regards,

Tony
Janusz Krzysztofik Sept. 20, 2018, 10:43 p.m. UTC | #5
Hi Tony,

On Thursday, September 20, 2018 11:23:26 PM CEST Tony Lindgren wrote:
> * Janusz Krzysztofik <jmkrzyszt@gmail.com> [180910 21:52]:
> > On Monday, September 10, 2018 1:44:16 AM CEST Janusz Krzysztofik wrote:
> > > 
> > > Convert modem related GPIO setup from integer space to GPIO descriptors.
> > > Also, restore original initialization order of the MODEM device and its
> > > related GPIO pins.
> > > 
> > > Cleanup of MODEM relaated regulator setup is postponed while waiting for
> > > upcoming conversion of fixed regulator API to GPIO descriptors.
> > > 
> > > 
> > > Janusz Krzysztofik (3):
> > >       ARM: OMAP1: ams-delta: assign MODEM IRQ from GPIO descriptor
> > >       ARM: OMAP1: ams-delta: initialize latch2 pins to safe values
> > >       ARM: OMAP1: ams-delta: register MODEM device earlier
> > > 
> > > 
> > > Changelog:
> > > v2:
> > > - rebased on v4.19-rc1
> > 
> > Hi Tony,
> > 
> > I forgot to mention: please apply on top of "[PATCH v3 0/3] ARM: OMAP1: ams-
> > delta: Complete driver gpiod migration" series. Sorry.
> 
> Hmm but then in that thread you said that it won't apply.. So I'm applying
> this series into omap-for-v4.20/omap1 branch. I just modified the second
> patch in this series for the unchanged header location.

OK, thank you.
Janusz

> I suggest you send the mtd patch separately to mtd maintainers, the fb patch
> separately to fb maintainers and then let's do the header move after all
> those are merged as a clean-up. That avoids some dependencies between these
> branches.
> 
> Regards,
> 
> Tony
>