| Message ID | 20190313142724.27446-1-cquast@hanoverdisplays.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ARM: dts: am335x: Replace numeric pinmux address with macro defines | expand |
* Christina Quast <cquast@hanoverdisplays.com> [190313 14:28]: > The defines are taken from dt-bindings/pinctrl/am335x.h > > Updated AM33XX_IOPAD to take three instead of two parameters: > AM33XX_IOPAD(register_offset, pin_direction_pullups, mux_mode) Thanks that works great for making things work eventually with #pinctrl-cells = <2> :) > + AM33XX_IOPAD(AM335X_PIN_UART1_RXD, PIN_INPUT, MUX_MODE0) /* uart1_rxd */ > + AM33XX_IOPAD(AM335X_PIN_UART1_TXD, PIN_INPUT, MUX_MODE0) /* uart1_txd * Since it sounds like you're modifying these with a script, just leave out any nop comments while at it where the comment is just the pad name already there in the new register define. Some comments might need to be preserved, but my guess is that they're mostly just the pad name. And I suggest you split this change to a seprate patch for each board so in case of trouble we can revert the changes for a single board if needed. Regards, Tony
* Christina Quast <cquast@hanoverdisplays.com> [190314 16:03]: > On 14/03/2019 16:05, Tony Lindgren wrote: > > * Christina Quast <cquast@hanoverdisplays.com> [190313 14:28]: > >> The defines are taken from dt-bindings/pinctrl/am335x.h > >> > >> Updated AM33XX_IOPAD to take three instead of two parameters: > >> AM33XX_IOPAD(register_offset, pin_direction_pullups, mux_mode) > > Thanks that works great for making things work eventually > > with #pinctrl-cells = <2> :) > > > >> + AM33XX_IOPAD(AM335X_PIN_UART1_RXD, PIN_INPUT, MUX_MODE0) /* uart1_rxd */ > >> + AM33XX_IOPAD(AM335X_PIN_UART1_TXD, PIN_INPUT, MUX_MODE0) /* uart1_txd * > > Since it sounds like you're modifying these with a script, > Who would do such a change by hand, anyways? That's too error-prone! Right :) > > just leave out any nop comments while at it where the comment > > is just the pad name already there in the new register > > define. Some comments might need to be preserved, but my > > guess is that they're mostly just the pad name. > > > > And I suggest you split this change to a seprate patch > > for each board so in case of trouble we can revert the > > changes for a single board if needed. > Is it really useful to have a change per board? Once the AM33XX_IOPAD > macro is changed and takes 3 arguments instead of 2, the old boards will > not compile anymore anyways. That's a good point. How about use some different name for the new macro? Something like AM33XX_PADCONF maybe? Note that there is a huge number of out-of-tree board specific dts files for various devices. So let's also keep the old macro for now. We could make produce a warning, then we can drop it later on few merge cycles later. Regards, Tony