| Message ID | 20200319173755.65082-1-tony@atomide.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | n_gsm serdev support and protocol driver for droid4 modem | expand |
Hi! > Here's v4 set of n_gsm serdev support patches, and the related protocol > driver for the modem found on Motorola Mapphone phones and tablets > like droid4. > > This series only adds basic character device support for the serdev > driver. Other serdev consumer drivers for specific devices will be > posted separately. > > The patches are against v5.6-rc series. And it would be good to get them into v5.7... pretty please :-). It seems to work for me... mostly. I checked out your ofono branch. Calls seem okay, but two smses arrived, but now phone does not seem to be logged into GSM network. Weird. Anyway, likely not a kernel problem. Tested-by: Pavel Machek <pavel@ucw.cz> Pavel
On Tue, Apr 21, 2020 at 01:59:20PM +0200, Pavel Machek wrote: > Hi! > > > Here's v4 set of n_gsm serdev support patches, and the related protocol > > driver for the modem found on Motorola Mapphone phones and tablets > > like droid4. > > > > This series only adds basic character device support for the serdev > > driver. Other serdev consumer drivers for specific devices will be > > posted separately. > > > > The patches are against v5.6-rc series. > > And it would be good to get them into v5.7... pretty please :-). No, 5.7 is not ok for this, and i think it already needs a respin as this is not in my patch queue anymore. thanks, greg k-h
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> [200421 12:49]: > On Tue, Apr 21, 2020 at 01:59:20PM +0200, Pavel Machek wrote: > > Hi! > > > > > Here's v4 set of n_gsm serdev support patches, and the related protocol > > > driver for the modem found on Motorola Mapphone phones and tablets > > > like droid4. > > > > > > This series only adds basic character device support for the serdev > > > driver. Other serdev consumer drivers for specific devices will be > > > posted separately. > > > > > > The patches are against v5.6-rc series. > > > > And it would be good to get them into v5.7... pretty please :-). > > No, 5.7 is not ok for this, and i think it already needs a respin as > this is not in my patch queue anymore. I'll send out an updated series. Thanks, Tony
On Tue 2020-04-21 14:48:20, Greg Kroah-Hartman wrote: > On Tue, Apr 21, 2020 at 01:59:20PM +0200, Pavel Machek wrote: > > Hi! > > > > > Here's v4 set of n_gsm serdev support patches, and the related protocol > > > driver for the modem found on Motorola Mapphone phones and tablets > > > like droid4. > > > > > > This series only adds basic character device support for the serdev > > > driver. Other serdev consumer drivers for specific devices will be > > > posted separately. > > > > > > The patches are against v5.6-rc series. > > > > And it would be good to get them into v5.7... pretty please :-). > > No, 5.7 is not ok for this, and i think it already needs a respin as > this is not in my patch queue anymore. Umm, I meant v5.8. OTOH it is new hardware support, and phone without modem is pretty much useless, so ... v5.7-rc3 should not be _completely_ out of question ;-). Pavel
Hi all, Here's v4 set of n_gsm serdev support patches, and the related protocol driver for the modem found on Motorola Mapphone phones and tablets like droid4. This series only adds basic character device support for the serdev driver. Other serdev consumer drivers for specific devices will be posted separately. The patches are against v5.6-rc series. Regards, Tony Changes since v4: - Use drivers/tty/serdev/protocol directory for the driver instead of drivers/mfd as discussed on the lists for v3 set of patches - Fix remove to call kfree only after removing device from the list Changes since v3: - Update list of folks in Cc, looks like I sent v3 only to Lee and lkml - Init privdata before motmdm_register_dlci calls gsm_serdev_register_dlci - Update binding based on Rob's comments for license and "allOf" Changes since v2: - Drop useless send_command indirection, use static motmdm_send_command Changes since v1: - Simplified usage and got rid of few pointless inline functions - Added consumer MFD driver, devicetree binding, and dts changes Tony Lindgren (4): tty: n_gsm: Add support for serdev drivers serdev: ngsm-motmdm: Add Motorola TS 27.010 serdev modem driver for droid4 dt-bindings: mfd: motmdm: Add binding for motorola-mdm ARM: dts: omap4-droid4: Enable basic modem support .../serdev/motorola,mapphone-mdm6600.yaml | 34 + .../boot/dts/motorola-mapphone-common.dtsi | 6 + drivers/tty/n_gsm.c | 372 +++++ drivers/tty/serdev/Kconfig | 3 + drivers/tty/serdev/Makefile | 2 + drivers/tty/serdev/protocol/Kconfig | 14 + drivers/tty/serdev/protocol/Makefile | 3 + .../tty/serdev/protocol/serdev-ngsm-motmdm.c | 1200 +++++++++++++++++ include/linux/serdev-gsm.h | 168 +++ 9 files changed, 1802 insertions(+) create mode 100644 Documentation/devicetree/bindings/serdev/motorola,mapphone-mdm6600.yaml create mode 100644 drivers/tty/serdev/protocol/Kconfig create mode 100644 drivers/tty/serdev/protocol/Makefile create mode 100644 drivers/tty/serdev/protocol/serdev-ngsm-motmdm.c create mode 100644 include/linux/serdev-gsm.h