mbox series

[00/10] mmc: convert tasklets to use new tasklet_setup()

Message ID 20200817083508.22657-1-allen.lkml@gmail.com
Headers show
Series mmc: convert tasklets to use new tasklet_setup() | expand

Message

Allen Pais Aug. 17, 2020, 8:34 a.m. UTC
Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
introduced a new tasklet initialization API. This series converts 
all the mmc drivers to use the new tasklet_setup() API

Allen Pais (10):
  mmc: atmel-mci: convert tasklets to use new tasklet_setup() API
  mmc: au1xmmc: convert tasklets to use new tasklet_setup() API
  mmc: cb710: convert tasklets to use new tasklet_setup() API
  mmc: dw_mmc: convert tasklets to use new tasklet_setup() API
  mmc: omap: convert tasklets to use new tasklet_setup() API
  mmc: renesas: convert tasklets to use new tasklet_setup() API
  mmc: s3cmci: convert tasklets to use new tasklet_setup() API
  mmc: tifm_sd: convert tasklets to use new tasklet_setup() API
  mmc: uniphier: convert tasklets to use new tasklet_setup() API
  mmc: via-sdmmc: convert tasklets to use new tasklet_setup() API

 drivers/mmc/host/atmel-mci.c                  |  6 +++---
 drivers/mmc/host/au1xmmc.c                    | 15 ++++++--------
 drivers/mmc/host/cb710-mmc.c                  | 11 +++++-----
 drivers/mmc/host/dw_mmc.c                     |  6 +++---
 drivers/mmc/host/omap.c                       |  7 +++----
 drivers/mmc/host/renesas_sdhi.h               |  1 +
 drivers/mmc/host/renesas_sdhi_core.c          |  2 ++
 drivers/mmc/host/renesas_sdhi_internal_dmac.c | 20 +++++++++----------
 drivers/mmc/host/renesas_sdhi_sys_dmac.c      |  9 ++++-----
 drivers/mmc/host/s3cmci.c                     |  6 +++---
 drivers/mmc/host/tifm_sd.c                    |  7 +++----
 drivers/mmc/host/uniphier-sd.c                | 14 ++++++-------
 drivers/mmc/host/via-sdmmc.c                  |  7 +++----
 13 files changed, 53 insertions(+), 58 deletions(-)

Comments

Masahiro Yamada Aug. 17, 2020, 12:53 p.m. UTC | #1
On Mon, Aug 17, 2020 at 5:35 PM Allen Pais <allen.lkml@gmail.com> wrote:
>
> Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> introduced a new tasklet initialization API. This series converts
> all the mmc drivers to use the new tasklet_setup() API


I did not know this was the direction to invest efforts
because I thought the threaded-irq was supposed to replace
the tasklet.





> Allen Pais (10):
>   mmc: atmel-mci: convert tasklets to use new tasklet_setup() API
>   mmc: au1xmmc: convert tasklets to use new tasklet_setup() API
>   mmc: cb710: convert tasklets to use new tasklet_setup() API
>   mmc: dw_mmc: convert tasklets to use new tasklet_setup() API
>   mmc: omap: convert tasklets to use new tasklet_setup() API
>   mmc: renesas: convert tasklets to use new tasklet_setup() API
>   mmc: s3cmci: convert tasklets to use new tasklet_setup() API
>   mmc: tifm_sd: convert tasklets to use new tasklet_setup() API
>   mmc: uniphier: convert tasklets to use new tasklet_setup() API
>   mmc: via-sdmmc: convert tasklets to use new tasklet_setup() API
>
>  drivers/mmc/host/atmel-mci.c                  |  6 +++---
>  drivers/mmc/host/au1xmmc.c                    | 15 ++++++--------
>  drivers/mmc/host/cb710-mmc.c                  | 11 +++++-----
>  drivers/mmc/host/dw_mmc.c                     |  6 +++---
>  drivers/mmc/host/omap.c                       |  7 +++----
>  drivers/mmc/host/renesas_sdhi.h               |  1 +
>  drivers/mmc/host/renesas_sdhi_core.c          |  2 ++
>  drivers/mmc/host/renesas_sdhi_internal_dmac.c | 20 +++++++++----------
>  drivers/mmc/host/renesas_sdhi_sys_dmac.c      |  9 ++++-----
>  drivers/mmc/host/s3cmci.c                     |  6 +++---
>  drivers/mmc/host/tifm_sd.c                    |  7 +++----
>  drivers/mmc/host/uniphier-sd.c                | 14 ++++++-------
>  drivers/mmc/host/via-sdmmc.c                  |  7 +++----
>  13 files changed, 53 insertions(+), 58 deletions(-)
>
> --
> 2.17.1
>


--
Best Regards
Masahiro Yamada
Kees Cook Aug. 17, 2020, 7:31 p.m. UTC | #2
On Mon, Aug 17, 2020 at 09:53:13PM +0900, Masahiro Yamada wrote:
> On Mon, Aug 17, 2020 at 5:35 PM Allen Pais <allen.lkml@gmail.com> wrote:
> >
> > Commit 12cc923f1ccc ("tasklet: Introduce new initialization API")'
> > introduced a new tasklet initialization API. This series converts
> > all the mmc drivers to use the new tasklet_setup() API
> 
> 
> I did not know this was the direction to invest efforts
> because I thought the threaded-irq was supposed to replace
> the tasklet.

Both can happen. It seemed to me that mechanical conversions from
tasklet to threaded-irq was not possible, though, so best to convert the
old API away from being a exploit target (saved arguments on the
heap) while conversions to threaded-irq can happen on a case-by-case
basis.