mbox series

[0/5] drop unused BACKLIGHT_GENERIC option

Message ID 20201130152137.24909-1-andrey.zhizhikin@leica-geosystems.com (mailing list archive)
Headers show
Series drop unused BACKLIGHT_GENERIC option | expand

Message

Andrey Zhizhikin Nov. 30, 2020, 3:21 p.m. UTC
Since the removal of generic_bl driver from the source tree in commit
7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
unused") BACKLIGHT_GENERIC config option became obsolete as well and
therefore subject to clean-up from all configuration files.

This series introduces patches to address this removal, separated by
architectures in the kernel tree.

Andrey Zhizhikin (5):
  ARM: configs: drop unused BACKLIGHT_GENERIC option
  arm64: defconfig: drop unused BACKLIGHT_GENERIC option
  MIPS: configs: drop unused BACKLIGHT_GENERIC option
  parisc: configs: drop unused BACKLIGHT_GENERIC option
  powerpc/configs: drop unused BACKLIGHT_GENERIC option

 arch/arm/configs/at91_dt_defconfig          | 1 -
 arch/arm/configs/cm_x300_defconfig          | 1 -
 arch/arm/configs/colibri_pxa300_defconfig   | 1 -
 arch/arm/configs/jornada720_defconfig       | 1 -
 arch/arm/configs/magician_defconfig         | 1 -
 arch/arm/configs/mini2440_defconfig         | 1 -
 arch/arm/configs/omap2plus_defconfig        | 1 -
 arch/arm/configs/pxa3xx_defconfig           | 1 -
 arch/arm/configs/qcom_defconfig             | 1 -
 arch/arm/configs/sama5_defconfig            | 1 -
 arch/arm/configs/sunxi_defconfig            | 1 -
 arch/arm/configs/tegra_defconfig            | 1 -
 arch/arm/configs/u8500_defconfig            | 1 -
 arch/arm64/configs/defconfig                | 1 -
 arch/mips/configs/gcw0_defconfig            | 1 -
 arch/mips/configs/gpr_defconfig             | 1 -
 arch/mips/configs/lemote2f_defconfig        | 1 -
 arch/mips/configs/loongson3_defconfig       | 1 -
 arch/mips/configs/mtx1_defconfig            | 1 -
 arch/mips/configs/rs90_defconfig            | 1 -
 arch/parisc/configs/generic-64bit_defconfig | 1 -
 arch/powerpc/configs/powernv_defconfig      | 1 -
 22 files changed, 22 deletions(-)


base-commit: b65054597872ce3aefbc6a666385eabdf9e288da
prerequisite-patch-id: bfd382cf1dc021d20204f10ea9403319c1c32b12
prerequisite-patch-id: 5397c0c8648bb3e0b830207ea867138c11c6e644
prerequisite-patch-id: a3c284dff5fe6d02828918a886db6a8ed3197e20

Comments

Sam Ravnborg Nov. 30, 2020, 7:11 p.m. UTC | #1
On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> Since the removal of generic_bl driver from the source tree in commit
> 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> unused") BACKLIGHT_GENERIC config option became obsolete as well and
> therefore subject to clean-up from all configuration files.
> 
> This series introduces patches to address this removal, separated by
> architectures in the kernel tree.
> 
> Andrey Zhizhikin (5):
>   ARM: configs: drop unused BACKLIGHT_GENERIC option
>   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
>   MIPS: configs: drop unused BACKLIGHT_GENERIC option
>   parisc: configs: drop unused BACKLIGHT_GENERIC option
>   powerpc/configs: drop unused BACKLIGHT_GENERIC option

For defconfigs I expect arch maintainers to do a make xxxdefconfig / make
savedefconfig / cp defconfig ... run now and then - this will remove
all such symbols.

If the patches goes in like they are submitted then:
Acked-by: Sam Ravnborg <sam@ravnborg.org>

> 
>  arch/arm/configs/at91_dt_defconfig          | 1 -
>  arch/arm/configs/cm_x300_defconfig          | 1 -
>  arch/arm/configs/colibri_pxa300_defconfig   | 1 -
>  arch/arm/configs/jornada720_defconfig       | 1 -
>  arch/arm/configs/magician_defconfig         | 1 -
>  arch/arm/configs/mini2440_defconfig         | 1 -
>  arch/arm/configs/omap2plus_defconfig        | 1 -
>  arch/arm/configs/pxa3xx_defconfig           | 1 -
>  arch/arm/configs/qcom_defconfig             | 1 -
>  arch/arm/configs/sama5_defconfig            | 1 -
>  arch/arm/configs/sunxi_defconfig            | 1 -
>  arch/arm/configs/tegra_defconfig            | 1 -
>  arch/arm/configs/u8500_defconfig            | 1 -
>  arch/arm64/configs/defconfig                | 1 -
>  arch/mips/configs/gcw0_defconfig            | 1 -
>  arch/mips/configs/gpr_defconfig             | 1 -
>  arch/mips/configs/lemote2f_defconfig        | 1 -
>  arch/mips/configs/loongson3_defconfig       | 1 -
>  arch/mips/configs/mtx1_defconfig            | 1 -
>  arch/mips/configs/rs90_defconfig            | 1 -
>  arch/parisc/configs/generic-64bit_defconfig | 1 -
>  arch/powerpc/configs/powernv_defconfig      | 1 -
>  22 files changed, 22 deletions(-)
> 
> 
> base-commit: b65054597872ce3aefbc6a666385eabdf9e288da
> prerequisite-patch-id: bfd382cf1dc021d20204f10ea9403319c1c32b12
> prerequisite-patch-id: 5397c0c8648bb3e0b830207ea867138c11c6e644
> prerequisite-patch-id: a3c284dff5fe6d02828918a886db6a8ed3197e20
> -- 
> 2.17.1
Andrey Zhizhikin Nov. 30, 2020, 7:56 p.m. UTC | #2
Hello Sam,

> -----Original Message-----
> From: Sam Ravnborg <sam@ravnborg.org>
> Sent: Monday, November 30, 2020 8:12 PM
> To: ZHIZHIKIN Andrey <andrey.zhizhikin@leica-geosystems.com>
> Cc: linux@armlinux.org.uk; nicolas.ferre@microchip.com;
> alexandre.belloni@bootlin.com; ludovic.desroches@microchip.com;
> tony@atomide.com; mripard@kernel.org; wens@csie.org;
> jernej.skrabec@siol.net; thierry.reding@gmail.com; jonathanh@nvidia.com;
> catalin.marinas@arm.com; will@kernel.org; tsbogend@alpha.franken.de;
> James.Bottomley@hansenpartnership.com; deller@gmx.de;
> mpe@ellerman.id.au; benh@kernel.crashing.org; paulus@samba.org;
> lee.jones@linaro.org; emil.l.velikov@gmail.com;
> daniel.thompson@linaro.org; krzk@kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org; linux-
> omap@vger.kernel.org; linux-tegra@vger.kernel.org; linux-
> mips@vger.kernel.org; linux-parisc@vger.kernel.org; linuxppc-
> dev@lists.ozlabs.org; Arnd Bergmann <arnd@arndb.de>; Olof Johansson
> <olof@lixom.net>
> Subject: Re: [PATCH 0/5] drop unused BACKLIGHT_GENERIC option
> 
> 
> On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> > Since the removal of generic_bl driver from the source tree in commit
> > 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> > unused") BACKLIGHT_GENERIC config option became obsolete as well and
> > therefore subject to clean-up from all configuration files.
> >
> > This series introduces patches to address this removal, separated by
> > architectures in the kernel tree.
> >
> > Andrey Zhizhikin (5):
> >   ARM: configs: drop unused BACKLIGHT_GENERIC option
> >   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
> >   MIPS: configs: drop unused BACKLIGHT_GENERIC option
> >   parisc: configs: drop unused BACKLIGHT_GENERIC option
> >   powerpc/configs: drop unused BACKLIGHT_GENERIC option
> 
> For defconfigs I expect arch maintainers to do a make xxxdefconfig / make
> savedefconfig / cp defconfig ... run now and then - this will remove all such
> symbols.

This series stretches across several archs, so I would expect that it could've been addressed for some of them but would take more time than submitting this "point fix" now, targeting one obsolete config option.

I've personally hit it for arm64 on the first place, and looking further into the option itself I realized that it is missing from the kernel tree completely and decided to fix all archs affected at once.

> 
> If the patches goes in like they are submitted then:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
> 
> >
> >  arch/arm/configs/at91_dt_defconfig          | 1 -
> >  arch/arm/configs/cm_x300_defconfig          | 1 -
> >  arch/arm/configs/colibri_pxa300_defconfig   | 1 -
> >  arch/arm/configs/jornada720_defconfig       | 1 -
> >  arch/arm/configs/magician_defconfig         | 1 -
> >  arch/arm/configs/mini2440_defconfig         | 1 -
> >  arch/arm/configs/omap2plus_defconfig        | 1 -
> >  arch/arm/configs/pxa3xx_defconfig           | 1 -
> >  arch/arm/configs/qcom_defconfig             | 1 -
> >  arch/arm/configs/sama5_defconfig            | 1 -
> >  arch/arm/configs/sunxi_defconfig            | 1 -
> >  arch/arm/configs/tegra_defconfig            | 1 -
> >  arch/arm/configs/u8500_defconfig            | 1 -
> >  arch/arm64/configs/defconfig                | 1 -
> >  arch/mips/configs/gcw0_defconfig            | 1 -
> >  arch/mips/configs/gpr_defconfig             | 1 -
> >  arch/mips/configs/lemote2f_defconfig        | 1 -
> >  arch/mips/configs/loongson3_defconfig       | 1 -
> >  arch/mips/configs/mtx1_defconfig            | 1 -
> >  arch/mips/configs/rs90_defconfig            | 1 -
> >  arch/parisc/configs/generic-64bit_defconfig | 1 -
> >  arch/powerpc/configs/powernv_defconfig      | 1 -
> >  22 files changed, 22 deletions(-)
> >
> >
> > base-commit: b65054597872ce3aefbc6a666385eabdf9e288da
> > prerequisite-patch-id: bfd382cf1dc021d20204f10ea9403319c1c32b12
> > prerequisite-patch-id: 5397c0c8648bb3e0b830207ea867138c11c6e644
> > prerequisite-patch-id: a3c284dff5fe6d02828918a886db6a8ed3197e20
> > --
> > 2.17.1

Regards,
Andrey
Krzysztof Kozlowski Nov. 30, 2020, 8:25 p.m. UTC | #3
On Mon, Nov 30, 2020 at 08:11:33PM +0100, Sam Ravnborg wrote:
> On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> > Since the removal of generic_bl driver from the source tree in commit
> > 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> > unused") BACKLIGHT_GENERIC config option became obsolete as well and
> > therefore subject to clean-up from all configuration files.
> > 
> > This series introduces patches to address this removal, separated by
> > architectures in the kernel tree.
> > 
> > Andrey Zhizhikin (5):
> >   ARM: configs: drop unused BACKLIGHT_GENERIC option
> >   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
> >   MIPS: configs: drop unused BACKLIGHT_GENERIC option
> >   parisc: configs: drop unused BACKLIGHT_GENERIC option
> >   powerpc/configs: drop unused BACKLIGHT_GENERIC option
> 
> For defconfigs I expect arch maintainers to do a make xxxdefconfig / make
> savedefconfig / cp defconfig ... run now and then - this will remove
> all such symbols.

savedefconfig can be tricky because of risk of loosing options:
1. it will remove options which became the default or became selected,
2. later when the default is changed or selecting option is removed, the
   first option from #1 will not be brought back.

This was already for example with DEBUG_FS and the conclusion that time
was - do not run savedefconfig automatically.

Therefore if some symbol(s) can be safely removed, patch is welcomed.

Best regards,
Krzysztof

> 
> If the patches goes in like they are submitted then:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Sam Ravnborg Nov. 30, 2020, 9:16 p.m. UTC | #4
Hi Krzysztof,
On Mon, Nov 30, 2020 at 10:25:01PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Nov 30, 2020 at 08:11:33PM +0100, Sam Ravnborg wrote:
> > On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> > > Since the removal of generic_bl driver from the source tree in commit
> > > 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> > > unused") BACKLIGHT_GENERIC config option became obsolete as well and
> > > therefore subject to clean-up from all configuration files.
> > > 
> > > This series introduces patches to address this removal, separated by
> > > architectures in the kernel tree.
> > > 
> > > Andrey Zhizhikin (5):
> > >   ARM: configs: drop unused BACKLIGHT_GENERIC option
> > >   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
> > >   MIPS: configs: drop unused BACKLIGHT_GENERIC option
> > >   parisc: configs: drop unused BACKLIGHT_GENERIC option
> > >   powerpc/configs: drop unused BACKLIGHT_GENERIC option
> > 
> > For defconfigs I expect arch maintainers to do a make xxxdefconfig / make
> > savedefconfig / cp defconfig ... run now and then - this will remove
> > all such symbols.
> 
> savedefconfig can be tricky because of risk of loosing options:
> 1. it will remove options which became the default or became selected,
> 2. later when the default is changed or selecting option is removed, the
>    first option from #1 will not be brought back.
> 
> This was already for example with DEBUG_FS and the conclusion that time
> was - do not run savedefconfig automatically.
> 
> Therefore if some symbol(s) can be safely removed, patch is welcomed.

Thanks for letting me know, I have missed that discussion and
was obviously not aware.
I already acked'ed the patches and hope the soc people will pick them
up.

	Sam
Daniel Thompson Dec. 1, 2020, 10:05 a.m. UTC | #5
On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> Since the removal of generic_bl driver from the source tree in commit
> 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> unused") BACKLIGHT_GENERIC config option became obsolete as well and
> therefore subject to clean-up from all configuration files.
> 
> This series introduces patches to address this removal, separated by
> architectures in the kernel tree.
> 
> Andrey Zhizhikin (5):
>   ARM: configs: drop unused BACKLIGHT_GENERIC option
>   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
>   MIPS: configs: drop unused BACKLIGHT_GENERIC option
>   parisc: configs: drop unused BACKLIGHT_GENERIC option
>   powerpc/configs: drop unused BACKLIGHT_GENERIC option

Whole series:
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>


Daniel.